feat: add silence detection callbacks for microphone control#89
Open
Jah-yee wants to merge 1 commit intoNVIDIA:mainfrom
Open
feat: add silence detection callbacks for microphone control#89Jah-yee wants to merge 1 commit intoNVIDIA:mainfrom
Jah-yee wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day,
Thank you for working on this project. I saw issue #85 about detecting when the model is about to talk to mute the microphone, and I wanted to help implement a solution.
This PR adds optional
on_silence_startandon_speech_startcallback parameters to theLMGenclass that can be used to detect when the model starts producing silence vs speech, enabling external microphone muting.Usage
These callbacks fire at the beginning and end of audio silence periods respectively, allowing external systems to know when it's safe to mute the microphone.
Thank you for your work on this project. I hope this small fix is helpful. Please let me know if there's anything to adjust.
Warmly, RoomWithOutRoof