Skip to content

Fix missing nvtx stack and host mem resource by exporting the symbols #3083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 2 commits into from
Jul 17, 2026
Merged

Fix missing nvtx stack and host mem resource by exporting the symbols #3083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02518f3
Export nvtx stack and host mem resource symbols
huuanhhuyn Jul 16, 2026
812921f
pre-commit run --all-files
huuanhhuyn Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cpp/include/raft/core/detail/nvtx_range_stack.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* SPDX-FileCopyrightText: Copyright (c) 2026, NVIDIA CORPORATION.
* SPDX-FileCopyrightText: Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
* SPDX-License-Identifier: Apache-2.0
*/
#pragma once
Expand Down Expand Up @@ -76,7 +76,7 @@ struct nvtx_range_name_stack {
std::shared_ptr<current_range> current_{std::make_shared<current_range>()};
};

inline thread_local nvtx_range_name_stack range_name_stack_instance{};
RAFT_EXPORT inline thread_local nvtx_range_name_stack range_name_stack_instance{};

} // namespace detail

Expand All @@ -85,7 +85,7 @@ inline thread_local nvtx_range_name_stack range_name_stack_instance{};
* Pass the returned shared_ptr to another thread to read this thread's current NVTX range name at
* any time.
*/
inline auto thread_local_current_range() -> std::shared_ptr<const current_range>
RAFT_EXPORT inline auto thread_local_current_range() -> std::shared_ptr<const current_range>
{
return detail::range_name_stack_instance.current();
}
Expand Down
9 changes: 5 additions & 4 deletions cpp/include/raft/mr/host_memory_resource.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* SPDX-FileCopyrightText: Copyright (c) 2026, NVIDIA CORPORATION.
* SPDX-FileCopyrightText: Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
* SPDX-License-Identifier: Apache-2.0
*/
#pragma once
Expand Down Expand Up @@ -46,7 +46,7 @@ struct default_host_resource_holder {
}
};

inline default_host_resource_holder default_host_resource_holder_{};
RAFT_EXPORT inline default_host_resource_holder default_host_resource_holder_{};

} // namespace detail

Expand All @@ -56,7 +56,7 @@ inline default_host_resource_holder default_host_resource_holder_{};
* Returns raft::mr::host_resource_ref pointing to the resource installed
* via set_default_host_resource(), or new_delete_resource() if none was set.
*/
inline auto get_default_host_resource() -> raft::mr::host_resource_ref
RAFT_EXPORT inline auto get_default_host_resource() -> raft::mr::host_resource_ref
{
return detail::default_host_resource_holder_.get();
}
Expand All @@ -69,7 +69,8 @@ inline auto get_default_host_resource() -> raft::mr::host_resource_ref
* @param res The resource to install.
* @return The previous default host resource.
*/
inline auto set_default_host_resource(raft::mr::host_resource res) -> raft::mr::host_resource
RAFT_EXPORT inline auto set_default_host_resource(raft::mr::host_resource res)
-> raft::mr::host_resource
{
return detail::default_host_resource_holder_.set(res);
}
Expand Down
Loading