Remove orphaned raft::runtime::matrix::select_k declaration#3084
Open
says1117 wants to merge 2 commits into
Open
Remove orphaned raft::runtime::matrix::select_k declaration#3084says1117 wants to merge 2 commits into
says1117 wants to merge 2 commits into
Conversation
Closes NVIDIA#3028. The header declared raft::runtime::matrix::select_k but had no corresponding implementation anywhere in the repo, was not listed as a CMake build source, and produced no linkable symbols in libraft. Traced to PR NVIDIA#2498 (implementation removed) and PR NVIDIA#2885 (later raft_runtime cleanup that missed this file). The working select_k implementation remains at raft/matrix/select_k.cuh.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughRemoved the Changes
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
…-select-k-runtime-header
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3028. The header declared raft::runtime::matrix::select_k but had no corresponding implementation anywhere in the repo, was not listed as a CMake build source, and produced no linkable symbols in libraft. Traced to PR #2498 (implementation removed) and PR #2885 (later raft_runtime cleanup that missed this file). The working select_k implementation remains at raft/matrix/select_k.cuh.