Skip to content

feat: register Holoscan skills catalog sync#103

Merged
mosheabr merged 2 commits into
NVIDIA:mainfrom
jcfr:add-holoscan-sdk
May 31, 2026
Merged

feat: register Holoscan skills catalog sync#103
mosheabr merged 2 commits into
NVIDIA:mainfrom
jcfr:add-holoscan-sdk

Conversation

@jcfr
Copy link
Copy Markdown
Contributor

@jcfr jcfr commented May 27, 2026

Onboarding type

  • New product onboarding (new components.d/<slug>.yml file)
  • Other (catalog change, README fix, infrastructure, etc.)

For new product onboarding — author affirmations

By submitting this PR, I confirm on behalf of my team:

  • Skills cleared for open source release per NVIDIA's internal IP review process (six-question check, all answers affirmative)
  • License selected: Apache 2.0 / CC-BY 4.0 / Dual (Apache 2.0 + CC-BY 4.0). Specify: Apache 2.0
  • No new license or new third-party component introduced beyond what the source repo already carries
  • Source repo is public and under an NVIDIA-owned GitHub org
  • .agents/skills/ or skills/ path used for new entries (or existing path retained for legacy entries per components.d/<slug>.yml)

NVIDIA contributors: see the internal onboarding guide for the IP review process details and license selection.

Reviewer checklist (OSS Skills PIC)

  • Author confirmations above are checked
  • components.d/<slug>.yml entry valid (required fields, unique catalog_dir, path exists in source repo, filename slug matches name)
  • SKILL.md frontmatter spec-compliant (at least one sampled)
  • No new license or third-party dependency requiring OSRB filing

All PRs

  • All commits signed off with DCO (git commit -s).
    If you forgot, run git rebase --signoff origin/main && git push --force-with-lease to retroactively sign all commits in your branch.

Other context (for non-onboarding PRs)

Add components.d/holoscan-sdk.yml so skills/ from
nvidia-holoscan/holoscan-sdk mirror into the public catalog under
skills/holoscan-sdk/. Today the skill collection focuses on installing
the SDK across container, Debian, Python wheel, Conda, and source paths.

Discussions is disabled on the public repo (feedback routes through the
Holoscan community channels at nvidia-holoscan.github.io), so the
generated README skips a Discussions link.

Signed-off-by: JC Fillion-Robin <jcfr@nvidia.com>
Restructures the Holoscan SDK component entry from the bulk pattern
(`path: skills/` + `catalog_dir: holoscan-sdk`, which lands every SDK
skill under `skills/holoscan-sdk/<skill>/` in this catalog) to the flat
layout: one entry per skill, each producing its own top-level
`skills/<catalog_dir>/` directory.

Per review feedback on the original onboarding PR — the flat layout
gives each skill its own discoverable catalog directory and avoids the
nested `holoscan-sdk/holoscan-install-*` paths that arise from the bulk
pattern.

The catalog_dir for each entry matches the source skill name (already
`holoscan-`-prefixed at authoring time), so the catalog layout mirrors
the source naming 1:1:

  - skills/holoscan-install-debian/
  - skills/holoscan-install-source/
  - skills/holoscan-install-wheel/
  - skills/holoscan-install-conda/
  - skills/holoscan-install-container/
  - skills/holoscan-setup/

Each `path` points at the corresponding source skill directory in
nvidia-holoscan/holoscan-sdk on `main`. The sync workflow rsyncs each
source directory into its named catalog directory verbatim.

Signed-off-by: JC Fillion-Robin <jcfr@nvidia.com>
@jcfr jcfr changed the title feat: register Holoscan SDK for skills catalog sync feat: register Holoscan skills catalog sync May 30, 2026
Copy link
Copy Markdown
Member

@keshprad keshprad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick flat-layout update. I ran the catalog onboarding checklist against this PR.

Blocking issue: the declared source paths do not exist in the public source repo on main.

components.d/holoscan-sdk.yml points at nvidia-holoscan/holoscan-sdk with these paths:

Skill Path exists on main SKILL.md skill-card.md skill.oms.sig evals/evals.json BENCHMARK.md
skills/holoscan-install-debian/ no, 404 n/a n/a n/a n/a n/a
skills/holoscan-install-source/ no, 404 n/a n/a n/a n/a n/a
skills/holoscan-install-wheel/ no, 404 n/a n/a n/a n/a n/a
skills/holoscan-install-conda/ no, 404 n/a n/a n/a n/a n/a
skills/holoscan-install-container/ no, 404 n/a n/a n/a n/a n/a
skills/holoscan-setup/ no, 404 n/a n/a n/a n/a n/a

I also checked the recursive tree for nvidia-holoscan/holoscan-sdk@main; it is not truncated and does not contain the declared holoscan-install-* / holoscan-setup skill paths, SKILL.md, skill.oms.sig, skill-card.md, evals.json, or BENCHMARK.md entries.

What passed:

  • PR is scoped to one new components.d/holoscan-sdk.yml file.
  • Filename slug matches name: Holoscan SDK.
  • Source repo is public, NVIDIA-owned, not archived, and Apache-2.0 licensed.
  • Discussions are disabled on the source repo and the component sets links.discussions: false.
  • SECURITY.md exists in the source repo.
  • The PR does not hand-edit README.md.
  • The two catalog commits have DCO sign-off and NVIDIA author/committer emails.
  • The new catalog_dir values do not collide with existing catalog entries.
  • The YAML uses the required flat one-entry-per-skill layout with product-prefixed names.

To unblock, please land the six skill directories in the public GitHub source repo, or update this component entry to a public NVIDIA GitHub repo/ref/path where those directories exist. Each catalog-bound skill directory needs SKILL.md, skill-card.md or SKILLCARD.yaml, skill.oms.sig, and evals/evals.json. Since BENCHMARK.md generation is now live, please also re-run /nvskills-ci after the public external-profile source PR is ready so the skill cards refresh and BENCHMARK.md is emitted.

@jcfr
Copy link
Copy Markdown
Contributor Author

jcfr commented May 31, 2026

Holoscan SDK 4.3 has just been released and associated skills are now available (link)

cc: @keshprad

Copy link
Copy Markdown
Collaborator

@mosheabr mosheabr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. JC built 6 Holoscan skills (debian, source, wheel, conda, container, setup), all with full 5-artifact set (SKILL.md + skill-card.md + skill.oms.sig + evals/ + BENCHMARK.md). Restructured to flat layout per the documented standard. Source repo public + Apache-2.0, NVIDIA-affiliated org.

@mosheabr mosheabr merged commit 3bdb834 into NVIDIA:main May 31, 2026
@jcfr jcfr deleted the add-holoscan-sdk branch May 31, 2026 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants