Skip to content

Add physical-ai-data-factory component config#198

Merged
mosheabr merged 2 commits into
NVIDIA:mainfrom
adityanjothi:ajothi/paidf-v1.0.0
May 31, 2026
Merged

Add physical-ai-data-factory component config#198
mosheabr merged 2 commits into
NVIDIA:mainfrom
adityanjothi:ajothi/paidf-v1.0.0

Conversation

@adityanjothi
Copy link
Copy Markdown
Contributor

@adityanjothi adityanjothi commented May 31, 2026

Onboarding type

  • New product onboarding (new components.d/<slug>.yml file)
  • Other (catalog change, README fix, infrastructure, etc.)

This PR onboards two new skills from NVIDIA/physical-ai-data-factory, grouped under the existing Physical AI product entry alongside the omniverse-* / physical-ai-* skills:

  • physical-ai-defect-image-generation
  • physical-ai-video-data-augmentation

For new product onboarding — author affirmations

By submitting this PR, I confirm on behalf of my team:

  • Skills cleared for open source release per NVIDIA's internal IP review process (six-question check, all answers affirmative)
  • License selected: Dual (Apache 2.0 + CC-BY 4.0), matching the source repo's LICENSE file
  • No new license or new third-party component introduced beyond what the source repo already carries
  • Source repo is public and under an NVIDIA-owned GitHub org (NVIDIA/physical-ai-data-factory)
  • skills/ path used for new entries

Reviewer checklist (OSS Skills PIC)

  • Author confirmations above are checked
  • components.d/<slug>.yml entry valid (required fields, unique catalog_dir, path exists in source repo, filename slug matches name)
  • SKILL.md frontmatter spec-compliant (at least one sampled)
  • No new license or third-party dependency requiring OSRB filing

All PRs

  • All commits signed off with DCO (git commit -s).

Signed-off-by: Adityan Jothi <ajothi@nvidia.com>
@adityanjothi adityanjothi force-pushed the ajothi/paidf-v1.0.0 branch from 7e00bab to 264abf7 Compare May 31, 2026 18:23
@mosheabr
Copy link
Copy Markdown
Collaborator

Thanks for the PR Aditya! Source content (NVIDIA/physical-ai-data-factory) is in great shape — dual-licensed CC-BY-4.0 + Apache-2.0, both skills carry the full 5-artifact set, all paths exist. A few things to fix before this can merge:

1. DCO sign-off (CI is failing)

The DCO check is currently failing because commit 7e00bab isn't signed off. Please run:

git commit --amend -s --no-edit
git push --force-with-lease

Or if there are multiple commits, git rebase --signoff origin/main && git push --force-with-lease will retroactively sign all commits in the branch.

2. Group under the existing "Physical AI" product

Per the product owner direction, all omniverse-* and physical-ai-* skills sit under a single Physical AI product entry in the catalog. The two new data-factory skills are part of that same product line — please change:

name: physical-ai-data-factory

to:

name: Physical AI

This way the catalog shows one consolidated "Physical AI" row covering all 7 skills (5 currently manually-staged from the internal Skill Hub repo + your 2 newly-synced from NVIDIA/physical-ai-data-factory). We're handling the README regeneration aggregation logic separately on our side so the two sources merge into one row cleanly.

3. Add links.discussions: false

Your source repo has GitHub Discussions disabled (has_discussions: false). The README regen would otherwise emit a broken Discussions link. Please add:

links:
  discussions: false

(SECURITY.md and CONTRIBUTING.md are already present in your repo, so the other link fields can stay at their defaults.)

4. Fill in the PR template

The current PR description is just a one-liner. Please use the new product onboarding template (you'll see it as a starting point when you edit the PR description). Specifically we need:

  • ✅ Skills cleared for open source release per NVIDIA's internal IP review process
  • ✅ License selected — Dual (Apache 2.0 + CC-BY 4.0), matching your LICENSE file
  • ✅ No new license or new third-party component beyond what the source repo carries
  • ✅ Source repo is public and under an NVIDIA-owned GitHub org
  • skills/ path used for new entries

Plus the reviewer checklist and DCO confirmation lines.

5. Minor — add trailing newline

The yml file is missing a trailing newline (\ No newline at end of file in the diff). Easy to fix.


Once those land, I'll re-review + merge. Let me know if anything's unclear on the signing flow or the product grouping. Tagging @sayalinvidia for sync-pipeline visibility.

Signed-off-by: Adityan Jothi <ajothi@nvidia.com>
@adityanjothi
Copy link
Copy Markdown
Contributor Author

Addressed the concerns, let me know if that looks @mosheabr . Thanks !

@mosheabr
Copy link
Copy Markdown
Collaborator

Thanks Aditya — all the feedback addressed cleanly. DCO + Verify Authors both green, naming aligned to Physical AI, link options correct.

One last sequencing note before we merge: this PR groups under name: Physical AI, which is the same display name as the existing entry in manual-components.yml (covering the 5 omniverse-* / physical-ai-* skills staged from the internal Skill Hub). With the current regenerate-readme.sh that would render two separate "Physical AI" rows in the README.

#200 (chore(regenerate-readme): aggregate rows by product name) adds the aggregation pass so synced + manual entries sharing a name render as one consolidated row. Once #200 lands, this PR merges cleanly and the next sync emits a single "Physical AI" row with 7 skills (5 manual + 2 synced from your repo).

I'm holding the merge of this PR until #200 is in. Should be a same-day turnaround. Tagging @sayalinvidia for visibility.

mosheabr added a commit that referenced this pull request May 31, 2026
Today the script emits one README row per yml entry — one row from each
components.d/<product>.yml plus one row from each entry in
manual-components.yml. When two entries share the same display `name`
(synced + manual under the same product), they render as two separate
rows with the same product name.

This blocks the upcoming Physical AI Data Factory onboarding (PR #198),
which adds a components.d entry named "Physical AI" — same name as the
existing manual entry that covers the 5 omniverse-* / physical-ai-*
skills from the internal Skill Hub.

Aggregation logic:
- Both loops now emit structured TSV (one column per cell, plus an
  is_manual flag) rather than pre-formatted markdown rows.
- An awk pass groups rows by lowercase name; for groups of 2+ entries:
  - catalog cells are concatenated with the existing " · " separator
  - skill counts are summed
  - synced row's metadata (description, source, version, link cells)
    wins over the manual row's em-dash defaults
- Single-entry rows pass through unchanged, so existing products with
  no name collision render byte-identically to today.

Verified locally:
- Current main state (only Physical AI in manual): renders one row,
  identical output to pre-aggregation behavior.
- Simulated PR #198 landing with `name: Physical AI` (5 manual +
  2 synced): renders one consolidated row with 7 skills, synced source
  cell, real link cells from the synced repo (issues, discussions,
  contributing, security).

Signed-off-by: Moshe Abramovitch <moshea@nvidia.com>
@mosheabr mosheabr merged commit c0ebb24 into NVIDIA:main May 31, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants