Cherry-pick lm-eval benchmark runner from sa-submission-q2-2026#122
Merged
ishandhanani merged 1 commit intomainfrom Apr 30, 2026
Merged
Cherry-pick lm-eval benchmark runner from sa-submission-q2-2026#122ishandhanani merged 1 commit intomainfrom
ishandhanani merged 1 commit intomainfrom
Conversation
* Add lm-eval benchmark runner for InferenceX evals Adds support for running lm-eval accuracy evaluations as a post-benchmark step, leveraging the InferenceX benchmark_lib.sh harness.
Merged
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
f61dbba(PR Add lm-eval benchmark runner for InferenceX evals #12, originally onsa-submission-q2-2026) ontomain, so thelm-evalbenchmark runner and theRUN_EVAL/EVAL_ONLYpost-eval flow indo_sweep.pyare available outside the SA submission branch.recipes/dsv4-agg-disaggperiodically merges frommainbut does not have the lm-eval logic, which is needed for SA CI to produce both speed and accuracy reports against the dsv4 recipes. Forward-porting tomainlets dsv4 (and other recipe branches) pick it up on their next merge.Conflict resolution
The cherry-pick had conflicts in 5 files. All were independent additions on both sides and were resolved by keeping both:
docs/accuracy.md— kept AIME mention from main andlm-evalsection from PRsrc/srtctl/benchmarks/__init__.py— keptcustom/trace_replayregistrations from main alongsidelm_evalsrc/srtctl/cli/do_sweep.py— kept HF model pre-cache helpers (main) alongside_run_post_eval(PR)tests/test_benchmarks.py— keptTestTraceReplayRunner+TestCustomDatasetLoader(main) alongsideTestLMEvalRunner+TestRunPostEval+TestSweepRunEvalIntegration(PR)tests/test_configs.py— keptTestHuggingFaceModelSupport(main) alongsideTestInfmaxWorkspaceMount(PR)Test plan
uv run ruff check src/srtctl/— passesuv run pytest tests/test_benchmarks.py -v— 56/56 pass (incl. allTestLMEvalRunner,TestRunPostEval,TestSweepRunEvalIntegration)uv run pytest tests/— 657 passed, 2 skippedRUN_EVAL=trueon a cluster🤖 Generated with Claude Code