feat: use pre-generated custom dataset for benchmarking MTP with chat template#63
Open
richardhuo-nv wants to merge 1 commit intosa-submission-q2-2026from
Open
feat: use pre-generated custom dataset for benchmarking MTP with chat template#63richardhuo-nv wants to merge 1 commit intosa-submission-q2-2026from
richardhuo-nv wants to merge 1 commit intosa-submission-q2-2026from
Conversation
fix fix fix fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a workaround for adding the chat template for MTP based benchmarking for GLM-5 model.
GLM-5 is using a custom tokenizer, invoking it multiple times will cause pmix failure at runtime.
Workaround is pre-generate the dataset with chat template and use it for MTP based benchmarking.
The config is like this: