Skip to content

fix(slinky): Skip exec scontrol show partition for DynamicNodes #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ravisoundar merged 1 commit into from
May 13, 2026
Merged

fix(slinky): Skip exec scontrol show partition for DynamicNodes #319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pkg/engines/slinky/engine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ const (

ConfigUpdateModeNone = "none"
ConfigUpdateModeSkeletonOnly = "skeleton-only"

dynamicShowPartitionNodes = "\tNodes=NONE"
)

type SlinkyEngine struct {
Expand Down Expand Up @@ -428,6 +430,11 @@ func (eng *SlinkyEngine) listPartitionNodes(ctx context.Context, sel *metav1.Lab
}

func (eng *SlinkyEngine) getPartitionNodes(ctx context.Context, partition string, params []any) (string, error) {
if eng.params.UseDynamicNodes {
klog.Infof("Skipping - scontrol show partition - when using useDynamicNodes flag")
return dynamicShowPartitionNodes, nil
}
Comment thread
ravisoundar marked this conversation as resolved.
Comment thread
ravisoundar marked this conversation as resolved.

if len(params) != 1 {
return "", fmt.Errorf("getPartitionNodes expects a namespace as a parameter")
}
Expand Down
4 changes: 4 additions & 0 deletions pkg/engines/slurm/slurm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,10 @@ func GetPartitionNodes(ctx context.Context, partition string, f *TopologyNodeFin
func parsePartitionNodes(partition string, data string) ([]string, error) {
match := partitionNodesRe.FindStringSubmatch(data)
if len(match) > 1 {
// If the nodes are NONE, return an empty list
if match[1] == "NONE" {
return []string{}, nil
}
return cluset.Compact(cluset.ExpandList(match[1])), nil
}

Expand Down
Loading