New Architecture and Expo 53 upgrade#1086
New Architecture and Expo 53 upgrade#1086kevinherdez merged 1 commit intoNWACus:kevinherdez/mapProjectfrom
Conversation
|
|
||
| return ( | ||
| <Modal visible={visible} onRequestClose={onClose} animationType="fade"> | ||
| <Modal visible={visible} onRequestClose={onClose} animationType="fade" presentationStyle="overFullScreen"> |
There was a problem hiding this comment.
presentationStyle="overFullScreen" is a work around for when the modal is presented from one of the tab views in the ForecastScreen.tsx. This keeps the view that the modal is being presented from in the background instead of removing it. It fixes an issue on iOS where the modal is being presented from a detached UIViewController because the view that the modals are being presented from are being removed from the view hierarchy
There was a problem hiding this comment.
The reason this diff is so big is because I removed the SafeAreaView from the modal. This created a big change according to git
There was a problem hiding this comment.
love it when git doesnt cooperate
| firstOpen = true; | ||
| // set back to not be null since we want a shared obs to have a back button | ||
| back = {title: 'Observations'}; | ||
| back = {title: 'Observations', href: undefined}; |
There was a problem hiding this comment.
i will admit this is not something I tested since sharing was not on yet - if we turn sharing on we should make sure this doesnt actually break anything
|
|
||
| const onPolygonPress = useCallback( | ||
| (_: OnPressEvent) => { | ||
| (_: object) => { |
There was a problem hiding this comment.
looks good! thank you! did you test on android and does the font actually show up? (vs all text missing) I assume yes but also remember that font worked on dev builds and only didnt work in preview lol so crossing my fingers we dont need to deal with that issue since we did enable new arch 🤞
I have been testing on Android and it looks good, but I'll create a preview build off of this branch to make sure that we're good there! |
|
I'm going to check this in to play around with getting it into preview based on off of the mapProject branch |
2 participants
This is a meaty change to get the project onto Expo 53 and the New Architecture
Most of the changes come directly from the last attempt to get this to work which can be found here:
The biggest differences are:
WeatherTab.tsxthat was temporary work around: Temporary work around for card collapse issue on Android #1078@mobilereality/react-native-select-pro. This package currently doesn't support the new architecture however I added a new patch based off of this work around: newArchEnabled MobileReality/react-native-select-pro#265 (comment)