Adjusts XYZ to Mol and XYZ File to Mol modules to assume angstrom and convert to bohr#9
Merged
Merged
Conversation
jwaldrop107
requested changes
Oct 6, 2025
Member
There was a problem hiding this comment.
This is on the right track, but I think we'll want to go about it differently. Instead of changing the default behavior, I would add an input to the module called "units" that defaults to "bohr". Then have the module check the value of that input to determine if the coordinate values need to be converted (and throw on non-permissible values).
ryanmrichard
reviewed
Oct 6, 2025
…ent of the xyz to molecule
jwaldrop107
approved these changes
Oct 8, 2025
Contributor
Author
|
I added in the unit scaling factor, I also "stress tested" the XYZ File to Molecule module with both a converted protein pdb from RCSB (4EMU, 2977 atoms) as well as an OpenMM generated solvent box, converted to an xyz (98880 atoms). The 4EMU took 290 ms, and the solvated box took 56952 ms. |
ryanmrichard
approved these changes
Oct 8, 2025
Contributor
|
🚀 [bumpr] Bumped! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is this pull request associated with an issue(s)?
No
Description
Converts angstrom-based XYZ files to bohr coordinates for Chemist conventions.
TODOs
None, r2g.