You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The fix is to add an optional second "conjugate" component cc to a volume_list whose phase (conjugated) is included in symmetry reductions via reduce. For the force calculations, cc is set according to the normal_direction.
cc @oskooi — this PR is just a rough draft right now, and could use a test (e.g. copied from #3161).
The fix proposed in this PR (ceff208) does not produce the expected result of zero force for the test involving an Ez dipole in 2d vacuum. (The test is based on the one provided in #129 and transcribed from Scheme to Python. The simulation layout is shown below.) Running the test script with the --with-symmetry flag (mirror symmetry in $x$and$y$) produces an incorrect force of 0.07380557. The result is -1.0482879755219221e-17 without symmetries (which is correct).
Additionally, using only a mirror symmetry in $x$ produces the correct result . However, a $y$ mirror symmetry produces 0.07380557 which is incorrect. This suggests there is a bug in the $y$ mirror-symmetry case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #129, following discussion in #3161.
The fix is to add an optional second "conjugate" component
ccto avolume_listwhose phase (conjugated) is included in symmetry reductions viareduce. For the force calculations,ccis set according to thenormal_direction.cc @oskooi — this PR is just a rough draft right now, and could use a test (e.g. copied from #3161).