Merged
Conversation
Added Windows, macOS, and Linux GitHub Actions build status badges to the README for better project visibility and build monitoring.
Introduces a shared matrix-config.yml workflow to define compiler and Qt version matrices for all platforms. Updates build workflows for Linux, macOS, and Windows to use this centralized configuration, enabling consistent and extensible matrix builds, including multiple Qt versions.
Wrapped qInfo() logging in a preprocessor check to avoid build failures on Qt5 under macOS. This ensures compatibility across different Qt versions and platforms.
Wrapped qInfo() logging in a preprocessor check to avoid build failures on Qt5 under macOS. This ensures compatibility across different Qt versions and platforms.
Updated CMakeLists.txt files to require Qt Core in addition to Widgets, and linked Qt::Core in targets. Added PM::PropertyGrid alias for PmPropertyGrid to standardize target naming.
Replaces forward declaration of PropertyGridTreeItem with an include directive for its header. Removes commented-out code and unnecessary struct declaration to improve code clarity and maintainability.
Replaces versionless Qt::Core and Qt::Widgets with versioned Qt${QT_VERSION_MAJOR}::Core and Qt${QT_VERSION_MAJOR}::Widgets in src/CMakeLists.txt to ensure compatibility with Qt versions prior to 5.15. Also removes redundant C++ standard settings and unused Qt linking in the example's CMakeLists.txt.
Introduced PM::internal::getMetaTypeName to handle differences in QMetaType name retrieval between Qt versions, ensuring compatibility with Qt 5.9 and above. Updated usages in PropertyEditor.cpp to use this new function. Also updated matrix-config.yml to remove unsupported Qt 5.6 from test matrix, clarifying the minimum supported version.
Moved Qt version compatibility functions (such as getMetaTypeName, getVariantTypeId, canConvert, and createDefaultVariantForType) from Property.h/cpp and PropertyEditor.cpp into a new internal header QtCompat_p.h. Updated includes throughout the codebase to use the new header, improving maintainability and separation of concerns.
Updated calls to QModelIndex::siblingAtColumn to use the PM::internal::siblingAtColumn function to support Qt5.12
Updated calls to QModelIndex::siblingAtColumn to use the PM::internal::siblingAtColumn function to support Qt5.9
Split the macOS build workflow into two jobs: - one targeting Intel-based macOS (macos-13) - the other for Apple Silicon (macos-latest). The ARM build excludes Qt5 versions as support for apple silicon started from Qt6
Set descriptive job names in Linux, macOS, and Windows GitHub Actions workflows using matrix variables for compiler and Qt version. The naming follows the vcpkg ports naming convention
Expanded README with clearer build instructions, CMake integration steps, and updated Qt version requirements (now Qt 5.9+).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added CI/CD workflow for Windows, Linux, macOS (ARM, Intel) with all Qt LTS versions starting from Qt5.9 onward