Refactor: Enhance module run endpoints with flexible secret handling #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Satti-Gowtham
commented
Feb 26, 2025
Satti-Gowtham
commented
- Updated HTTP server endpoints to accept payload with optional nested input and secrets
- Modified WebSocket and package worker run methods to support optional secrets parameter
- Simplified secret decryption using just RSA decryption method
- Removed deprecated user secret creation endpoint
- Removed AES secret generation from server initialization
- Updated HTTP server endpoints to accept payload with optional nested input and secrets - Modified WebSocket and package worker run methods to support optional secrets parameter - Simplified secret decryption using just RSA decryption method - Removed deprecated user secret creation endpoint - Removed AES secret generation from server initialization
Satti-Gowtham
requested review from
enricorotundo,
moarshy and
richardblythman
Satti-Gowtham
temporarily deployed
to
development
GitHub Actions
Inactive
Satti-Gowtham
temporarily deployed
to
development
GitHub Actions
Inactive
Satti-Gowtham
temporarily deployed
to
development
GitHub Actions
Inactive
Satti-Gowtham
temporarily deployed
to
development
GitHub Actions
Inactive
Satti-Gowtham
temporarily deployed
to
development
GitHub Actions
Inactive
Satti-Gowtham
temporarily deployed
to
development
GitHub Actions
Inactive
- Updated gRPC proto definition to include optional secrets in ModuleRunRequest - Modified gRPC server to process and decrypt secrets for module runs - Updated package worker to handle optional secrets parameter in module run functions - Added Secret message type to proto definition - Implemented flexible secret handling with optional kwargs support in module run methods
Satti-Gowtham
temporarily deployed
to
development
GitHub Actions
Inactive
Satti-Gowtham
had a problem deploying
to
development
GitHub Actions
Error
Satti-Gowtham
had a problem deploying
to
development
GitHub Actions
Failure
Satti-Gowtham
temporarily deployed
to
development
GitHub Actions
Inactive
Satti-Gowtham
temporarily deployed
to
development
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.