Wait for completedAt in remote dispatch polling#113
Open
abrahmasandra wants to merge 13 commits into
Open
Conversation
Contributor
|
Let's hold off on merging this as we are discussing the desired DX for a HITL feature. |
added 4 commits
May 20, 2026 14:12
…-input-required-status # Conflicts: # packages/narada-pyodide/src/narada/window.py # packages/narada/src/narada/window.py
abrahmasandra
commented
May 22, 2026
abrahmasandra
commented
May 22, 2026
abrahmasandra
commented
May 26, 2026
added 7 commits
May 26, 2026 15:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDK polling previously stopped based on status, so an active input-required wait could be mistaken for a completed request. This PR changes remote-dispatch polling to continue until completedAt is set and adds an on_input_required callback that fires once per active inputId with the typed action metadata. The design mirrors the backend contract directly: status communicates active state, completedAt communicates finality, and inputId prevents duplicate callback invocations for the same user-input step.