Seb/freshness#136
Open
sebzhao wants to merge 3 commits into
Open
Conversation
xTRam1
reviewed
May 29, 2026
Contributor
xTRam1
left a comment
xTRam1
left a comment
There was a problem hiding this comment.
I am not approving this one yet because the PR currently has a failing required freshness check. The diff itself is the same intended freshness enforcement pattern and the submodule pointer is already pinned to current architecture-docs/main (92c03f8a0c337679d5bf8aaf354b0cccbacb3a09), so this is not a stale-pointer/code issue.
The failing job shows:
GH_TOKEN:
IS_UNTRUSTED_PR: false
Missing ARCHITECTURE_DOCS_READ_PAT or ALL_REPO_CHECKOUT_TOKEN.
Cannot verify architecture-docs freshness without read access to NaradaAI/architecture-docs.
So the SDK repo needs one of these repository/org secrets configured with read access to NaradaAI/architecture-docs:
ARCHITECTURE_DOCS_READ_PAT
# or
ALL_REPO_CHECKOUT_TOKENAfter that secret is configured, rerun check-submodule-current. If it passes, this PR should be mergeable from my review perspective.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Freshness test fix