[codex] add agentic selector precondition parameter#139
Draft
kssteven418 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pre_condsupport toAgenticSelectorRequestserialization.pre_condon both Python and Pyodideagentic_selectormethods.Scope note
This PR was created from a clean
origin/mainworktree and intentionally excludes an unrelated local Pyodide workflow-trace compatibility fix that was present in the original dirty checkout.Validation
uv run ruff check packages/narada-core/src/narada_core/actions/models.py packages/narada-pyodide/src/narada/window.py packages/narada/src/narada/window.pyuv run python -c 'from narada_core.actions.models import AgenticSelectorRequest; req=AgenticSelectorRequest(action={"type":"click"}, selectors={"tag_name":"BUTTON"}, fallback_operator_query="Click Submit", pre_cond="check Submit exists"); dumped=req.model_dump(); assert dumped["pre_cond"] == "check Submit exists"; req2=AgenticSelectorRequest(action={"type":"click"}, selectors={"tag_name":"BUTTON"}, fallback_operator_query="Click Submit"); assert "pre_cond" not in req2.model_dump(); print("pre_cond serialization ok")'git diff --check origin/main...HEAD