Reduce unnecessary waiting when initializing cloud browsers#67
Merged
Conversation
volodymyr-narada
requested changes
Feb 12, 2026
Comment on lines
+237
to
+249
| # Wait for browser window ID. The extension can take a bit to be installed, so we retry a | ||
| # few times. | ||
| max_attempts = 5 | ||
| for attempt in range(max_attempts): | ||
| try: | ||
| browser_window_id = await self._wait_for_browser_window_id( | ||
| initialization_page, config | ||
| ) | ||
| except NaradaExtensionMissingError: | ||
| if attempt == max_attempts - 1: | ||
| raise | ||
| logging.info("Waiting for Narada extension to be installed...") | ||
| await asyncio.sleep(1) |
Contributor
There was a problem hiding this comment.
what happens if browser_window_id is not initialized even after 5 retries? I think we should send a "stop-session" request with "failed" status
volodymyr-narada
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the frontend
/initializepage automatically transitions to the signed in page after a successful login with a custom token, we no longer need to do the extra wait & refresh in this SDK.