Skip to content

allow access cloud session downloads#75

Merged
zizhengtai merged 5 commits into
mainfrom
volodymyr/sdk-access-downloaded-files
Mar 10, 2026
Merged

allow access cloud session downloads#75
zizhengtai merged 5 commits into
mainfrom
volodymyr/sdk-access-downloaded-files

Conversation

@volodymyr-narada

@volodymyr-narada volodymyr-narada commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

Note

Medium Risk
Adds new API calls that return presigned download URLs for cloud-session files and changes cloud session shutdown timeout; incorrect backend responses/permissions could expose or break download access.

Overview
Adds SDK support to list files downloaded in a cloud browser session. CloudBrowserWindow and RemoteBrowserWindow now expose get_downloaded_files(), which fetches the session’s downloads and resolves each file’s presigned GET URL via new replay endpoints.

Also updates the cloud browser example to demonstrate retrieving downloaded files, removes stale TODOs in cloud init, and increases the stop-session request timeout from 10s to 40s.

Written by Cursor Bugbot for commit 504a0bf. This will update automatically on new commits. Configure here.

Comment thread examples/cloud_browser.py
Comment thread packages/narada/src/narada/client.py Outdated
Comment thread examples/cloud_browser.py
Comment thread examples/cloud_browser.py

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

base_url=self._base_url,
auth_headers=self._auth_headers,
session_id=self._cloud_browser_session_id,
)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate get_downloaded_files implementation across classes

Low Severity

get_downloaded_files is implemented separately on both RemoteBrowserWindow and CloudBrowserWindow, with identical logic (calling _get_cloud_browser_downloads with the same parameters). Both classes already expose a cloud_browser_session_id property, so a single implementation in BaseBrowserWindow using that property could consolidate the two, eliminating the duplicated logic and reducing the risk of future inconsistency.

Additional Locations (1)

Fix in Cursor Fix in Web

@zizhengtai zizhengtai merged commit 348429f into main Mar 10, 2026
5 checks passed
@zizhengtai zizhengtai deleted the volodymyr/sdk-access-downloaded-files branch March 10, 2026 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants