Skip to content

reload page if browser window id not found and try again #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zizhengtai merged 4 commits into from
Apr 28, 2026
Merged

reload page if browser window id not found and try again #96

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
580704a
reload page if browser window id not found and try again
volodymyr-narada Apr 28, 2026
031db9f
reload page if browser window id not found
volodymyr-narada Apr 28, 2026
9932aac
formatting upd
volodymyr-narada Apr 28, 2026
47b6d13
remove unneded sleep
volodymyr-narada Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/narada/src/narada/client.py
View file
Open in desktop

@volodymyr-narada volodymyr-narada Apr 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes it does not detect the browser window id even thought it is visible on the cloud session replay. In such cases reloading the page helps.

The default timeout is 30s, I put 8s in a loop of max 5 retries which would give us 45s max (8*5 + 5 sleep second). On practice, it takes 1-2 iterations (8-16 seconds), so this is better to reload each 8 seconds instead of reloading after default 30s.

Original file line number Diff line number Diff line change
Expand Up @@ -283,18 +283,25 @@ async def _initialize_cloud_browser_window(

# Wait for browser window ID. The extension can take a bit to be installed, so we retry a
# few times.
max_attempts = 5
max_attempts = 10
for attempt in range(max_attempts):
try:
browser_window_id = await self._wait_for_browser_window_id(
initialization_page, config
initialization_page,
config,
timeout=4_000,
)
break
except NaradaExtensionMissingError:
if attempt == max_attempts - 1:
raise
logging.info("Waiting for Narada extension to be installed...")
await asyncio.sleep(1)
except NaradaTimeoutError:
if attempt == max_attempts - 1:
raise
# If browser window ID is not found, reload the page and try again
await initialization_page.reload()

cloud_window = CloudBrowserWindow(
browser_window_id=browser_window_id,
Expand Down
Loading