Conversation
Collaborator
malihass
commented
Apr 13, 2026
malihass
commented
- Adding multiphase flow equation to the doc
- Adding an explanation of how the Henry's constant is calculated
…issues and we will move to pytorch
malihass
changed the title
Collaborator
|
All looks good to me. Thanks for adding this part to the documentation. |
fmuni
approved these changes
Apr 15, 2026
Collaborator
fmuni
left a comment
fmuni
left a comment
There was a problem hiding this comment.
All looks good to me. Thanks for adding this part to the documentation.
github-actions bot
pushed a commit
that referenced
this pull request
Apr 15, 2026
* remove string warning * merge stl gen and mesh * remove calibration subinstall for now. Tensorflow is giving too many issues and we will move to pytorch * remove preprocess from index * add a multiphase model section * move references to inside multiphase model * add Henry's constant conversion * use CP CC notations * update pixi lock and fix spelling * update pixi lock * add higbie model * used math instead of code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.