Skip to content

Trying coverage tests on self-hosted runners and coveralls#11535

Open
mitchute wants to merge 15 commits intodevelopfrom
revamp-coverage-tests
Open

Trying coverage tests on self-hosted runners and coveralls#11535
mitchute wants to merge 15 commits intodevelopfrom
revamp-coverage-tests

Conversation

@mitchute
Copy link
Copy Markdown
Collaborator

Pull request overview

  • I've gotten a more powerful self-hosted runner online now, so this is just a bit of testing to see if we can migrate coverage tests to self-hosted runners and coveralls.

Description of the purpose of this PR

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies
  • If adding/removing any output files (e.g., eplustbl.*)
    • Update ..\scripts\Epl-run.bat
    • Update ..\scripts\RunEPlus.bat
    • Update ..\src\EPLaunch\ MainModule.bas, epl-ui.frm, and epl.vbp (VersionComments)
    • Update ...github\workflows\energyplus.py

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@mitchute mitchute added DoNotPublish Includes changes that shouldn't be reported in the changelog DoNotMerge Code that requires additional attention and investigation labels Apr 21, 2026
@github-actions
Copy link
Copy Markdown

⚠️ Regressions detected on ubuntu-24.04 for commit 6f82914

Regression Summary
  • ESO Small Diffs: 706
  • Table Small Diffs: 392
  • MTR Small Diffs: 524
  • Table String Diffs: 177
  • EIO: 397
  • JSON Small Diffs: 2
  • ZSZ Small Diffs: 72
  • Table Big Diffs: 36
  • ERR: 14
  • MTR Big Diffs: 2
  • ESO Big Diffs: 10
  • SSZ Small Diffs: 13
  • EDD: 4
  • JSON Big Diffs: 2

@github-actions
Copy link
Copy Markdown

⚠️ Regressions detected on ubuntu-24.04 for commit d070a72

Regression Summary
  • ESO Small Diffs: 706
  • Table Small Diffs: 392
  • Table String Diffs: 177
  • MTR Small Diffs: 524
  • EIO: 397
  • JSON Small Diffs: 2
  • ZSZ Small Diffs: 72
  • Table Big Diffs: 36
  • ERR: 14
  • MTR Big Diffs: 2
  • ESO Big Diffs: 10
  • SSZ Small Diffs: 13
  • EDD: 4
  • JSON Big Diffs: 2

@github-actions
Copy link
Copy Markdown

⚠️ Regressions detected on macos-14 for commit f52a278

Regression Summary
  • EIO: 1
  • Table Big Diffs: 1
  • Table String Diffs: 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DoNotMerge Code that requires additional attention and investigation DoNotPublish Includes changes that shouldn't be reported in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants