Convert UserDefinedComponents to use std::vector#11541
Open
Convert UserDefinedComponents to use std::vector#11541
Conversation
mitchute
commented
Apr 24, 2026
| // GetWtoAHPCoilCapacity(CoolingCoilType, this->m_CoolingCoilName, errFlag ); | ||
| HeatingCoilInletNode = thisHeatCoil.Air(1).InletNodeNum; | ||
| HeatingCoilOutletNode = thisHeatCoil.Air(1).OutletNodeNum; | ||
| HeatingCoilInletNode = thisHeatCoil.AirConnections[primaryConnIdx].InletNodeNum; |
Collaborator
Author
There was a problem hiding this comment.
UserDefinedComponets.hh has another Air object, so I renamed this for clarity. I also renamed the hardcoded indices for what seems to me like what was intended.
Comment on lines
+176
to
+182
| if (thisLoop < 0) { | ||
| ShowFatalError(state, | ||
| EnergyPlus::format("SimUserDefinedPlantComponent: did not find plant connection for {}. Loop number called from ={}, " | ||
| "loop side called from ={}.", | ||
| this->Name, | ||
| calledFromLocation.loopNum, | ||
| calledFromLocation.loopSideNum)); |
Collaborator
Author
There was a problem hiding this comment.
A couple new error messages mirror what was already in this file. Reporting back the integer values of loopNum and loopSideNum may not be the clearest way to do it. We do have some strings we can map to for the loopSideNum. Maybe adding that is another step here.
|
|
||
| this->initialize(state, calledFromLocation.loopNum, myLoad); |
Collaborator
Author
There was a problem hiding this comment.
Some reordering of initialize and oneTimeInit to make sure things are happing in the right order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
Description of the purpose of this PR
Pull Request Author
Reviewer