Skip to content

Convert UserDefinedComponents to use std::vector#11541

Open
mitchute wants to merge 2 commits intodevelopfrom
array1-userdefinedcomponents
Open

Convert UserDefinedComponents to use std::vector#11541
mitchute wants to merge 2 commits intodevelopfrom
array1-userdefinedcomponents

Conversation

@mitchute
Copy link
Copy Markdown
Collaborator

Pull request overview

  • Converts UserDefinedComponents to use std::vector
  • Minor renaming of air connections for clarity

Description of the purpose of this PR

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies
  • If adding/removing any output files (e.g., eplustbl.*)
    • Update ..\scripts\Epl-run.bat
    • Update ..\scripts\RunEPlus.bat
    • Update ..\src\EPLaunch\ MainModule.bas, epl-ui.frm, and epl.vbp (VersionComments)
    • Update ...github\workflows\energyplus.py

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@mitchute mitchute added the Refactoring Includes code changes that don't change the functionality of the program, just perform refactoring label Apr 24, 2026
// GetWtoAHPCoilCapacity(CoolingCoilType, this->m_CoolingCoilName, errFlag );
HeatingCoilInletNode = thisHeatCoil.Air(1).InletNodeNum;
HeatingCoilOutletNode = thisHeatCoil.Air(1).OutletNodeNum;
HeatingCoilInletNode = thisHeatCoil.AirConnections[primaryConnIdx].InletNodeNum;
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UserDefinedComponets.hh has another Air object, so I renamed this for clarity. I also renamed the hardcoded indices for what seems to me like what was intended.

Comment on lines +176 to +182
if (thisLoop < 0) {
ShowFatalError(state,
EnergyPlus::format("SimUserDefinedPlantComponent: did not find plant connection for {}. Loop number called from ={}, "
"loop side called from ={}.",
this->Name,
calledFromLocation.loopNum,
calledFromLocation.loopSideNum));
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple new error messages mirror what was already in this file. Reporting back the integer values of loopNum and loopSideNum may not be the clearest way to do it. We do have some strings we can map to for the loopSideNum. Maybe adding that is another step here.


this->initialize(state, calledFromLocation.loopNum, myLoad);
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some reordering of initialize and oneTimeInit to make sure things are happing in the right order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Refactoring Includes code changes that don't change the functionality of the program, just perform refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants