Conversation
|
This PR changes variable/meter and node numbering and broke all unit tests that rely on hard-coded numbers for these, a few for meters, many more for nodes. I have been able to fix most of these, but a few remain:
I tried a few fixes in one of the tests (I think the first one) and they didn't work for reasons that I couldn't parse.
Cannot get these to reproduce locally (mac arm64). Strangely, my local build had some other broken unit tests (e.g., in
This test uses very strange node number arithmetic that makes no sense to me. I tried to fix it both the way it was and the way I thought it should have been and neither of them worked. There is also a broken integration test that I need some advice on how to approach. |
The coil API refactor continues. Here, the various
GetCoilInputfunctions are moved toinit_state()and hilarity/madness ensues.