Skip to content

Coil API Refactor (Part III -- move GetCoilInputs to init_state())#11548

Open
amirroth wants to merge 12 commits intodevelopfrom
CoilAPI2
Open

Coil API Refactor (Part III -- move GetCoilInputs to init_state())#11548
amirroth wants to merge 12 commits intodevelopfrom
CoilAPI2

Conversation

@amirroth
Copy link
Copy Markdown
Collaborator

The coil API refactor continues. Here, the various GetCoilInput functions are moved to init_state() and hilarity/madness ensues.

@amirroth amirroth added Refactoring Includes code changes that don't change the functionality of the program, just perform refactoring NotIDDChange Code does not impact IDD (can be merged after IO freeze) labels Apr 27, 2026
@amirroth
Copy link
Copy Markdown
Collaborator Author

This PR changes variable/meter and node numbering and broke all unit tests that rely on hard-coded numbers for these, a few for meters, many more for nodes. I have been able to fix most of these, but a few remain:

  • EnergyPlusFixture.AirflowNetwork_CheckMultistageHeatingCoil
  • EnergyPlusFixture.AirflowNetwork_DuctSizingTest
  • EnergyPlusFixture.AirflowNetwork_TestFanModel
  • EnergyPlusFixture.AirflowNetwork_UserDefinedDuctViewFactors

I tried a few fixes in one of the tests (I think the first one) and they didn't work for reasons that I couldn't parse. AirflowNetwork has its own parallel node logic that I probably needed to fix also. May need @jasondegraw help in fixing these up.

  • EnergyPlusFixture.ExerciseHVACDXHeatPumpSystem
  • EnergyPlusFixture.SimulationManager_OutputDebuggingData
  • EnergyPlusFixture.UnitHeater_HWHeatingCoilUAAutoSizingTest

Cannot get these to reproduce locally (mac arm64). Strangely, my local build had some other broken unit tests (e.g., in WaterCoilsTest fixture) that didn't show up in CI. I don't know how to handle these.

  • EnergyPlusFixture.MixedAir_HXBypassOptionTest

This test uses very strange node number arithmetic that makes no sense to me. I tried to fix it both the way it was and the way I thought it should have been and neither of them worked.

There is also a broken integration test that I need some advice on how to approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NotIDDChange Code does not impact IDD (can be merged after IO freeze) Refactoring Includes code changes that don't change the functionality of the program, just perform refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants