CppCheck: Fix remaining warnings

[dareumnam]

Pull request overview

• Fix the following CppCheck warnings:
  • unpreciseMathCall
  • uninitvar
  • constVariablePointer
  • duplicateCondition
  • cstyleCast
  • redundantAssignment
  • redundantInitialization
  • useInitializationList
  • unmatchedSuppression
  • stlIfStrFind
  • arrayIndexThenCheck
  • uselessAssignmentArg
  • noExplicitConstructor
  • shadowVariable
  • constVariablePointer
  • unreadVariable and etc

Description of the purpose of this PR

Pull Request Author

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies
• If adding/removing any output files (e.g., eplustbl.*)
  • Update ..\scripts\Epl-run.bat
  • Update ..\scripts\RunEPlus.bat
  • Update ..\src\EPLaunch\ MainModule.bas, epl-ui.frm, and epl.vbp (VersionComments)
  • Update ...github\workflows\energyplus.py

Reviewer

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[amirroth]

Why? the variable is a terminal unit object, not a terminal unit index.

[mitchute]

This was addressed here: 3ea96c6

[github-actions]

⚠️ Regressions detected on macos-14 for commit 5d18b95

Regression Summary

• ESO Small Diffs: 258
• EIO: 205
• MTR Small Diffs: 211
• Table Small Diffs: 150
• Table String Diffs: 23
• JSON Small Diffs: 1
• Table Big Diffs: 8
• ERR: 6
• MTR Big Diffs: 1
• EDD: 2
• ESO Big Diffs: 2
• JSON Big Diffs: 1

• View Results
• Download Regressions

[github-actions]

⚠️ Regressions detected on ubuntu-24.04 for commit 5d18b95

Regression Summary

• ESO Small Diffs: 256
• EIO: 201
• MTR Small Diffs: 209
• Table Small Diffs: 147
• Table String Diffs: 26
• JSON Small Diffs: 2
• Table Big Diffs: 9
• ERR: 6
• MTR Big Diffs: 1
• EDD: 1
• ESO Big Diffs: 3

• View Results
• Download Regressions

[mitchute]

@dareumnam I reverted the std::log1p and std::expm1 changes. From my local testing, these appear to be what is causing the diffs. I think they should be equivalent to what you did, so I don't have an explanation for the behavior at the moment. If this comes back clean, we can just address the other review comments, and then merge it and move on.

[mitchute]

Thanks @dareumnam. This is ready to go. Merging.

[dareumnam]

Thanks, @mitchute. I'll double-check the rest of the issues. If any of them need to be fixed, I'll make one last follow-up PR.