Skip to content

#11565: ZoneHVAC:HybridUnitaryHVAC - Min/Max OA Temp should not be constrained by default#11573

Draft
kevin-moos wants to merge 4 commits intoNatLabRockies:developfrom
bigladder:HybridUnitaryHVAC-remove-constraints-for-blank-outdoor-air-temperatures
Draft

#11565: ZoneHVAC:HybridUnitaryHVAC - Min/Max OA Temp should not be constrained by default#11573
kevin-moos wants to merge 4 commits intoNatLabRockies:developfrom
bigladder:HybridUnitaryHVAC-remove-constraints-for-blank-outdoor-air-temperatures

Conversation

@kevin-moos
Copy link
Copy Markdown
Contributor

Pull request overview

Description of the purpose of this PR

Add bools to track whether Min/Max OA Temp constraints were left blank in the IDF. Update logic to ignore these constraints when left blank.

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies
  • If adding/removing any output files (e.g., eplustbl.*)
    • Update ..\scripts\Epl-run.bat
    • Update ..\scripts\RunEPlus.bat
    • Update ..\src\EPLaunch\ MainModule.bas, epl-ui.frm, and epl.vbp (VersionComments)
    • Update ...github\workflows\energyplus.py

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ZoneHVAC:HybridUnitaryHVAC - Min/Max OA Temp should not be constrained by default

3 participants