#11566: ZoneHVAC:HybridUnitaryHVAC - Return Air constraints not referenced

[kevin-moos]

Pull request overview

• Fixes ZoneHVAC:HybridUnitaryHVAC - Return Air constraints not referenced #11566

Description of the purpose of this PR

Add logic to check Return Air constraints for temperature, humidity ratio, and relative humidity. Add bools to track whether Min/Max Return Temp constraints were left blank in the IDF. Update logic to ignore these constraints when left blank.

Pull Request Author

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies
• If adding/removing any output files (e.g., eplustbl.*)
  • Update ..\scripts\Epl-run.bat
  • Update ..\scripts\RunEPlus.bat
  • Update ..\src\EPLaunch\ MainModule.bas, epl-ui.frm, and epl.vbp (VersionComments)
  • Update ...github\workflows\energyplus.py

Reviewer

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[rraustad]

Should the 2nd Minimum_RA_Temp_Blank be Max?

[kevin-moos]

Yes, thanks for catching that one!

[rraustad]

Doesn't OAT have the same issue with a blank Min/Max OAT? I also don't see how the other default limits are applied? e.g., Min/Max humrat of 0.0 and 0.1 or RH of 0% and 100%, where do these get set? All these CMode::Initialize functions just return true, so how do any of the warnings following these function calls get executed? i.e., lines 610, 618 and 628.

[kevin-moos]

Thanks, Rich. I'm still working on this PR so it's not quite ready for review. Min/Max OAT does have the same issue, but that's being addressed in a different PR. The defaults for HumRat and RH are coming from the IDD during input processing. The temperatures don't have defaults because they're supposed to be unconstrained according to the documentation. And you're correct about those Initialize functions - all of those warnings are basically unreachable code that could be removed since IDD validation has already happened by this point.

[rraustad]

OK, I see the defaults now in the idd. This object has lots of inputs and I was looking at the wrong inputs.