Skip to content

Bump miniconda action for upgraded node usage#722

Merged
johnjasa merged 1 commit intoNatLabRockies:developfrom
RHammond2:patch/conda-action
May 4, 2026
Merged

Bump miniconda action for upgraded node usage#722
johnjasa merged 1 commit intoNatLabRockies:developfrom
RHammond2:patch/conda-action

Conversation

@RHammond2
Copy link
Copy Markdown
Collaborator

Bump setup-miniconda version

This PR updates the version of the conda-incubator/setup-miniconda action to be compliant with the new minimum node.js versions in GitHub Actions.

Section 1: Type of Contribution

  • Feature Enhancement
    • Framework
    • New Model
    • Updated Model
    • Tools/Utilities
    • Other (please describe):
  • Bug Fix
  • Documentation Update
  • CI Changes
  • Other (please describe):

Section 2: Draft PR Checklist

  • Open draft PR
  • Describe the feature that will be added
  • Fill out TODO list steps
  • Describe requested feedback from reviewers on draft PR
  • Complete Section 7: New Model Checklist (if applicable)

TODO:

  • Step 1
  • Step 2

Type of Reviewer Feedback Requested (on Draft PR)

Structural feedback:

Implementation feedback:

Other feedback:

Section 3: General PR Checklist

  • PR description thoroughly describes the new feature, bug fix, etc.
  • Added tests for new functionality or bug fixes
  • Tests pass (If not, and this is expected, please elaborate in the Section 6: Test Results)
  • Documentation
    • Docstrings are up-to-date
    • Related docs/ files are up-to-date, or added when necessary
    • Documentation has been rebuilt successfully
    • Examples have been updated (if applicable)
  • CHANGELOG.md
    • At least one complete sentence has been provided to describe the changes made in this PR
    • After the above, a hyperlink has been provided to the PR using the following format:
      "A complete thought. [PR XYZ]((https://github.com/NatLabRockies/H2Integrate/pull/XYZ)", where
      XYZ should be replaced with the actual number.

Section 4: Related Issues

N/A

Section 5: Impacted Areas of the Software

Section 5.1: New Files

  • path/to/file.extension
    • method1: What and why something was changed in one sentence or less.

Section 5.2: Modified Files

  • .github/workflows/ci.yml
    • conda-incubator/setup-miniconda: v3 -> v4

Section 6: Additional Supporting Information

See build error in PR #719 for details: https://github.com/NatLabRockies/H2Integrate/actions/runs/25237586503/job/74006945926?pr=719

Section 7: Test Results, if applicable

N/A

Section 8 (Optional): New Model Checklist

  • Model Structure:
    • Follows established naming conventions outlined in docs/developer_guide/coding_guidelines.md
    • Used attrs class to define the Config to load in attributes for the model
      • If applicable: inherit from BaseConfig or CostModelBaseConfig
    • Added: initialize() method, setup() method, compute() method
      • If applicable: inherit from CostModelBaseClass
  • Integration: Model has been properly integrated into H2Integrate
    • Added to supported_models.py
    • If a new commodity_type is added, update create_financial_model in h2integrate_model.py
  • Tests: Unit tests have been added for the new model
    • Pytest-style unit tests
    • Unit tests are in a "test" folder within the folder a new model was added to
    • If applicable add integration tests
  • Example: If applicable, a working example demonstrating the new model has been created
    • Input file comments
    • Run file comments
    • Example has been tested and runs successfully in test_all_examples.py
  • Documentation:
    • Write docstrings using the Google style
    • Model added to the main models list in docs/user_guide/model_overview.md
      • Model documentation page added to the appropriate docs/ section
      • <model_name>.md is added to the _toc.yml
    • Run generate_class_hierarchy.py to update the class hierarchy diagram in docs/developer_guide/class_structure.md

@RHammond2 RHammond2 requested a review from johnjasa May 4, 2026 14:53
@RHammond2 RHammond2 changed the title bump miniconda action for upgraded node usage Bump miniconda action for upgraded node usage May 4, 2026
@RHammond2 RHammond2 added bug Something isn't working labels May 4, 2026
@johnjasa johnjasa enabled auto-merge May 4, 2026 15:32
@johnjasa johnjasa merged commit 6056898 into NatLabRockies:develop May 4, 2026
12 checks passed
@RHammond2 RHammond2 deleted the patch/conda-action branch May 4, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants