fix: attributes#130
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
==========================================
+ Coverage 95.55% 95.93% +0.37%
==========================================
Files 8 8
Lines 1823 1919 +96
==========================================
+ Hits 1742 1841 +99
+ Misses 81 78 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pesap
left a comment
There was a problem hiding this comment.
Left 3 inline comments. Main fixes requested: early validation for explicit attribute records missing name, plus regression test for that case. I also linked follow up issue #132 for chunking standardization so we can keep this PR focused.
c29cdc1 to
8dcc908
Compare
|
@akrivi , is this ready for review? |
|
yes! |
pesap
left a comment
There was a problem hiding this comment.
Approved after fixing the broken MyST/Sphinx API reference link in docs/source/howtos/add_attributes.md and validating the docs build locally.
This PR:
Updates
copy_objectto also copy object-level attributes (t_attribute_data) in addition to memberships and properties.This is particularly important for classes such as
ClassEnum.Horizon, where key defining characteristics (e.g. Date From, Step Count, Chrono Date From, Look-ahead At a Time) are stored as attributes. Previously, these were not copied, resulting in incomplete duplicated objects.Introduces
add_attributes_from_recordsfor efficient bulk insertion of attribute values.Implements
delete_attribute,get_attributes,check_attribute_existsDocumentation updates related to attributes