Feat/custom height UI 281#288
Open
RLiNREL wants to merge 4 commits into
Open
Conversation
RLiNREL
requested review from
Copilot and
sameersk2k
and removed request for
Copilot
July 20, 2026 20:57
Contributor
There was a problem hiding this comment.
Pull request overview
Implements custom hub height entry in the UI to address #281 by allowing interpolated hub height selection (with clamping/no extrapolation) and reorganizing the hub height settings UI.
Changes:
- Added
resolveHubHeightutility to clamp/snap hub height values based on model interpolation behavior. - Refactored hub height “interpolation” configuration from
number | nulltobooleanand updated hub height settings UI to include a numeric text field. - Minor UI text tweak and formatting normalization in GTM init script.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| windwatts-ui/src/utils/turbine.ts | Adds resolveHubHeight helper for clamping/snap-to-nearest logic. |
| windwatts-ui/src/types/Heights.ts | Changes interpolation from number | null to boolean. |
| windwatts-ui/src/constants/hubSettings.ts | Updates hub height model config to use boolean interpolation. |
| windwatts-ui/src/components/settings/LossAssumptionSettings.tsx | Minor copy change (punctuation). |
| windwatts-ui/src/components/settings/HubHeightSettings.tsx | Adds hub height text input + updated slider behavior using interpolation boolean. |
| windwatts-ui/public/gtm-init.js | Formatting-only quote/style normalization. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Close #281 UI
Checklist
developmake formatandmake verifydevelopfeat/...,fix/...,docs/...,chore/...)feat: add new feature,fix: resolve bug,docs: update documentation)Others: e.g. Screenshots if UI change