fix(theme): raise the VCD/apps cover to center on the games cover's axis#205
Merged
Conversation
…s the games cover NathanNeurotic (HW): "VCD cover art should absolutely be adjusted to raise a bit -- it's sitting low on the right side, and looks off kilter as a result." The VCD view renders with the APPS element family, so its cover is appsMain16. ItemCover initialises with ALIGN_CENTER (themes.c), i.e. x/y is the element's CENTRE, and a negative y anchors from the bottom (posY = (screenHeight + y) scaled by usedHeight; a positive y is absolute). main16 (PS2 games): y=240 h=256 -> centre 240, spans 112..368 appsMain16 (apps/VCD): y=-198 h=185 -> centre 282, spans 190..375 So the two covers were roughly BOTTOM-aligned, and because the VCD/apps cover is square (185 vs 256 tall) that put its centre 42px BELOW the games cover on the same right-hand slot -- it read as sunk and off-kilter next to a PS2 cover. Centre it on the same axis as the games cover: appsMain16: y=-198 -> y=240 -> centre 240, spans 147..332 Using the positive form also matches main16 exactly: a negative y additionally SCALES with usedHeight (so it drifted differently on a 448-line theme), a positive one does not -- the two covers now share one anchor rule instead of two. Affects the Apps page as well as the VCD view (same element, same square-vs-tall mismatch), which is the consistent result: both now sit centred on the games cover's axis. conf_theme_OPL.cfg is embedded in the ELF (MISC_OBJS -> conf_theme_OPL.o), so the rebuild bakes it in. Builds clean (make opl.elf, exit 0). Geometry is computed, not rendered -- wants a visual check. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (17)
🔇 Additional comments (1)
📝 WalkthroughWalkthroughThe OPL theme configuration moves the ChangesTheme layout
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report (NathanNeurotic, HW)
Cause
The VCD view renders with the apps element family, so its cover is
appsMain16.ItemCoverinitialises withALIGN_CENTER(themes.c:2142) — x/y is the element's centre — and a negative y anchors from the bottom (posY = (screenHeight + y), scaled byusedHeight), while a positive y is absolute.main16(PS2 games)240appsMain16(apps/VCD)-198The two were roughly bottom-aligned — and because the VCD/apps cover is square (185 vs 256 tall), that put its centre 42px below the games cover in the same right-hand slot. Hence "low on the right side / off kilter."
Fix
appsMain16: y=-198 → y=240→ centre 240, spans 147–332: the same axis as the games cover.Using the positive form also matches
main16exactly — a negative y additionally scales withusedHeight(so it drifted differently on a 448-line theme) while a positive one doesn't. Both covers now share one anchor rule instead of two.This affects the Apps page as well as the VCD view (same element, same square-vs-tall mismatch) — which is the consistent outcome: both centre on the games cover's axis.
Validation
conf_theme_OPL.cfgis embedded in the ELF (MISC_OBJS→conf_theme_OPL.o), so the rebuild bakes it in. Builds clean (make opl.elf, exit 0).Geometry is computed, not rendered — this wants your eyes on it. If 240 reads too high, the knob is just that one number.
🤖 Generated with Claude Code
Summary by CodeRabbit