Skip to content

elf_loader: skip SIF teardown for HDD-backed embedded loader #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NathanNeurotic wants to merge 1 commit into
base: BETA-11-play
Choose a base branch
from
+4 −2
Open

elf_loader: skip SIF teardown for HDD-backed embedded loader #403

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/elf_loader/src/elf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,10 +377,12 @@ static int ExecuteViaEmbeddedLoader(const char *partition_context, const char *l
}
}

SifExitIopHeap();
if (!is_hdd_backed_exec_path(partition_context)) {
SifExitIopHeap();
SifExitRpc();
SifExitCmd();
FlushCache(0);
}
FlushCache(0);
Comment on lines +380 to +385
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The indentation of the code within the if block and the following FlushCache call is incorrect. It should follow the existing tab-based indentation style of the file to maintain readability.

	if (!is_hdd_backed_exec_path(partition_context)) {
		SifExitIopHeap();
		SifExitRpc();
		SifExitCmd();
	}
	FlushCache(0);

FlushCache(2);

ret = ExecPS2((void *)boot_header->entry, 0, final_argc, launch_argv);
Expand Down
Loading