Emit intermediate results on the mostRecent-unique path#3740
Open
apmoriarty wants to merge 2 commits into
Open
Emit intermediate results on the mostRecent-unique path#3740apmoriarty wants to merge 2 commits into
apmoriarty wants to merge 2 commits into
Conversation
UniqueTransform.apply() returned null immediately after updating the mostRecent map, short-circuiting before the timeout/intermediate-result check. A long-running mostRecent-unique accumulation therefore never emitted a keep-alive intermediate page. Fall through to the existing timeout check instead of returning early. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
apmoriarty
added
Integration Tested
no-downstream-effects
and removed
Integration Tested
labels
apmoriarty
marked this pull request as ready for review
July 24, 2026 18:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UniqueTransform.apply()returnednullimmediately after updating the mostRecent-unique backing map, short-circuiting before the timeout/intermediate-result check. A long-running mostRecent-unique accumulation therefore never emitted a keep-alive intermediate page.Test plan
UniqueTransformMostRecentTestasserting an intermediate result is emitted once the per-page timeout is exceededmvn -pl warehouse/query-core -Dtest="datawave.query.transformer.**,datawave.query.common.grouping.**" testpasses🤖 Generated with Claude Code