Skip to content

ci: remove binary upload workflow and SKIP_COMMIT_HELPER_POSTINSTALL #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yujeong-jeon merged 1 commit into from
Mar 5, 2026
Merged

ci: remove binary upload workflow and SKIP_COMMIT_HELPER_POSTINSTALL #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/detect-changed-packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ jobs:
runs-on: ubuntu-latest
env:
GITHUB_TOKEN: ${{ secrets.ACTION_TOKEN }}
SKIP_COMMIT_HELPER_POSTINSTALL: 1
steps:
- name: Checkout Repo
uses: actions/checkout@v3
Expand Down
94 changes: 0 additions & 94 deletions .github/workflows/release-asset.yaml
View file
Open in desktop

This file was deleted.

35 changes: 0 additions & 35 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,7 @@ jobs:
(github.event_name == 'issue_comment' && needs.get-branch.result == 'success'))
outputs:
published: ${{ steps.publish_release.outputs.published || steps.publish_canary.outputs.published || steps.publish_rc.outputs.published }}
commithelperGoWillBePublished: ${{ steps.checkCommitHelperGo.outputs.commithelperGoWillBePublished }}
packageVersion: ${{ steps.checkCommitHelperGo.outputs.publishedVersion }}
env:
SKIP_COMMIT_HELPER_POSTINSTALL: 1
GITHUB_TOKEN: ${{ secrets.ACTION_TOKEN }}
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
steps:
Expand Down Expand Up @@ -121,35 +118,3 @@ jobs:
create_release: true
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Check if commithelper-go was published
id: checkCommitHelperGo
if: always()
run: |
echo "publish_release publishedPackages: '${{ steps.publish_release.outputs.publishedPackages }}'"
echo "publish_canary publishedPackages: '${{ steps.publish_canary.outputs.publishedPackages }}'"
echo "publish_rc publishedPackages: '${{ steps.publish_rc.outputs.publishedPackages }}'"
publishedPackages='${{ steps.publish_release.outputs.publishedPackages || steps.publish_canary.outputs.publishedPackages || steps.publish_rc.outputs.publishedPackages }}'
echo "resolved publishedPackages: '$publishedPackages'"
if [ -z "$publishedPackages" ] || [ "$publishedPackages" == "null" ]; then
echo "commithelperGoWillBePublished=false" >> $GITHUB_OUTPUT
else
commithelperGo=$(echo "$publishedPackages" | jq -r '.[] | select(.name == "@naverpay/commithelper-go")')
if [ -n "$commithelperGo" ] && [ "$commithelperGo" != "null" ]; then
echo "commithelperGoWillBePublished=true" >> $GITHUB_OUTPUT
# Extract the actual published version (handles canary/RC versions)
version=$(echo "$commithelperGo" | jq -r '.version')
echo "publishedVersion=$version" >> $GITHUB_OUTPUT
else
echo "commithelperGoWillBePublished=false" >> $GITHUB_OUTPUT
fi
fi

upload-assets:
needs: release
if: always() && needs.release.outputs.published == 'true' && needs.release.outputs.commithelperGoWillBePublished == 'true'
uses: ./.github/workflows/release-asset.yaml
with:
package: '@naverpay/commithelper-go'
version: ${{ needs.release.outputs.packageVersion }}
secrets: inherit