Use monotonic timestamp in scan result

[rohitsangwan01]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @rohitsangwan01, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the UniversalBle library by adding comprehensive support for Bluetooth Low Energy (BLE) service data within scan results. This feature allows applications to access additional advertisement data provided by BLE devices, which is crucial for identifying and interacting with specific services. The changes span across the core data models, Pigeon definitions, and platform-specific implementations for Android, iOS/macOS, Linux, and Windows, ensuring a unified experience. Additionally, the Android implementation benefits from improved scan performance and more precise timestamping.

Highlights

• Service Data Support: Introduced serviceData to BleDevice and UniversalBleScanResult models, enabling the retrieval of service-specific advertisement data during BLE scans across all platforms (Android, iOS/macOS, Linux, Windows).
• Android Scan Improvements: Updated Android's BLE scanning to use SCAN_MODE_LOW_LATENCY for potentially faster scan results and switched to timestampNanos for more accurate, monotonic timestamps in scan results.
• Cross-Platform Integration: Implemented platform-specific logic for extracting and mapping service data, ensuring consistent data availability through the UniversalBle API.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly refactors the code to use monotonic timestamps for BLE scan results, which is a good improvement for accuracy. It also removes the usage of System.currentTimeMillis() where a monotonic timestamp isn't available, setting it to null instead. However, I've identified an unrelated change that sets the scan mode to low latency, which will increase power consumption. I've added a comment to address this.

[gemini-code-assist]

Hardcoding the scan mode to SCAN_MODE_LOW_LATENCY will significantly increase power consumption. This mode is generally recommended only for short, foreground scans. This change appears unrelated to the PR's main goal of updating timestamp handling.

To prevent unexpected battery drain for users, please consider removing these lines. If low-latency scanning is a required feature, it would be better to make it a configurable option.