fix(core): make isContentEmpty robust to malformed and unclosed tags#60
Merged
fix(core): make isContentEmpty robust to malformed and unclosed tags#60
Conversation
Replace the regex-based strip (<[^>]*>) with a linear scan over angle brackets. The previous approach could misclassify strings with an unclosed '<' (e.g. literal text or partial tags) because the pattern left odd fragments or dropped visible characters in edge cases. - Treat text after '<' with no following '>' as visible content, so partial tags are not treated as empty. - Preserve existing behavior for normal HTML: empty/whitespace-only paragraphs and plain whitespace still count as empty. Tests cover unclosed brackets, bare tags, multi-line ASCII whitespace inside tags, and tagless whitespace-only input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the regex-based strip (<[^>]*>) with a linear scan over angle brackets. The previous approach could misclassify strings with an unclosed '<' (e.g. literal text or partial tags) because the pattern left odd fragments or dropped visible characters in edge cases.
Tests cover unclosed brackets, bare tags, multi-line ASCII whitespace inside tags, and tagless whitespace-only input.