Skip to content

Potential fix for code scanning alert no. 7: DOM text reinterpreted as HTML #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ndevu12 merged 1 commit into from
Mar 29, 2026
Merged

Potential fix for code scanning alert no. 7: DOM text reinterpreted as HTML #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion src/components/Dialogs/ImageDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,29 @@ export function ImageDialog() {
}, []);

// ── Compute preview URL (either file preview or typed URL) ─
const previewSrc = source === 'file' ? filePreview : url.trim() || null;
const getSafePreviewSrc = (): string | null => {
if (source === 'file') {
return filePreview;
}

const trimmed = url.trim();
if (!trimmed) {
return null;
}

try {
const parsed = new URL(trimmed, window.location.origin);
const scheme = parsed.protocol.replace(':', '').toLowerCase();
if (scheme === 'http' || scheme === 'https' || scheme === 'data') {
return trimmed;
}
return null;
} catch {
return null;
}
};

const previewSrc = getSafePreviewSrc();
const showPreview = !!previewSrc;

return (
Expand Down
Loading