Skip to content

Potential fix for code scanning alert no. 21: Information exposure through an exception #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ndevu12 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Potential fix for code scanning alert no. 21: Information exposure through an exception #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions api/views/sales.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,9 @@ def confirm(self, request, pk=None):
sales_order=so,
confirmed_by=request.user,
)
except DjangoValidationError as e:
except DjangoValidationError:
return Response(
{"detail": e.message if hasattr(e, "message") else str(e)},
{"detail": "Invalid data for confirming sales order."},
status=status.HTTP_400_BAD_REQUEST,
)
return Response(self.get_serializer(so).data)
Expand All @@ -71,9 +71,9 @@ def cancel(self, request, pk=None):
service = SalesService()
try:
service.cancel_order(sales_order=so)
except DjangoValidationError as e:
except DjangoValidationError:
return Response(
{"detail": e.message if hasattr(e, "message") else str(e)},
{"detail": "Invalid data for cancelling sales order."},
status=status.HTTP_400_BAD_REQUEST,
)
return Response(self.get_serializer(so).data)
Expand Down Expand Up @@ -103,9 +103,9 @@ def process(self, request, pk=None):
dispatch=dispatch,
dispatched_by=request.user,
)
except DjangoValidationError as e:
except DjangoValidationError:
return Response(
{"detail": e.message if hasattr(e, "message") else str(e)},
{"detail": "Invalid data for processing dispatch."},
status=status.HTTP_400_BAD_REQUEST,
)
dispatch.refresh_from_db()
Expand Down
Loading