Skip to content

WIP: Updating Quay/StoPlace#846

Open
JohanEntur wants to merge 1 commit intoNeTEx-CEN:v2.0from
entur:stop_place_quay_boarding_position_type
Open

WIP: Updating Quay/StoPlace#846
JohanEntur wants to merge 1 commit intoNeTEx-CEN:v2.0from
entur:stop_place_quay_boarding_position_type

Conversation

@JohanEntur
Copy link
Collaborator

Discussed in https://3.basecamp.com/3256016/buckets/2570434/messages/8335437909.
I wanted this to be discussed first, but since we are running out of meetings, and this doesnt come up, I'll just post this right away.

Again, thanks to my colleague for composing the actual PR.

@skinkie
Copy link
Contributor

skinkie commented Apr 7, 2025

Is QuayLayoutTypeEnumeration in use?

Can the different types have proper documentation?

@ue71603
Copy link
Contributor

ue71603 commented Apr 9, 2025

with proper documentation Stefan means:

			<xsd:enumeration value="lane">
					<xsd:annotation>
						<xsd:documentation>What does this really mean?</xsd:documentation>
					</xsd:annotation>
			</xsd:enumeration>

Also, always add such a thing to one of the appropriate example file (each element should be used at least in one example.
Here e.g. one in https://github.com/NeTEx-CEN/NeTEx/tree/next/examples/functions/site

@ue71603
Copy link
Contributor

ue71603 commented Apr 9, 2025

Otherwise looks good.

@ue71603 ue71603 requested review from Aurige, duexw, skinkie and trurlurl April 9, 2025 17:41
@ue71603 ue71603 added this to the netex_2.0 milestone Apr 9, 2025
@ue71603 ue71603 added enhancement non semantic enhacement: technical enhancement, etc. needs documentation update The NeTEx document needs to be updated fix_now labels Apr 9, 2025
<xsd:enumeration value="other"/>
</xsd:restriction>
</xsd:simpleType>
<xsd:simpleType name="StopPlaceCategoryEnumeration">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between "Category" and "Type" - i.e., why has the name StopPlaceCategoryEnumeration been chosen instead of StopPlaceTypeEnumeration (similar to the existing StopTypeEnumeration and other type names)?

@Aurige
Copy link
Contributor

Aurige commented Apr 17, 2025

I initially thought that this would be for next release (not for v2), since it requires quite a lot of work:

  • articulation with existing enum: we will probably need to deprecate some values, and articulation between StopTypeEnumeration and StopPlaceCategoryEnumeration (may be chose a better name as pointed by @trurlurl ), also articulation between busStopWithinRoadwayBoarding or tramStopWithinRoadwayBoarding with the new QuayLayoutTypeEnumeration, etc.
  • for now the StopPlaceCategory is only in the StopPlaceView which is king of limited
  • it will also most probably require some discussion with the Transmodel group
  • etc.

So I would rather target it to a milestone after 2.0

@ue71603 ue71603 modified the milestones: netex_2.0, netex_2.1 Apr 19, 2025
@ue71603
Copy link
Contributor

ue71603 commented Apr 19, 2025

@Aurige ok for me either way. moved to 2.1 for the time being

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement non semantic enhacement: technical enhancement, etc. fix_now needs documentation update The NeTEx document needs to be updated needs transmodel update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants