fix: record deserialization with $ref metadata#44
Merged
Conversation
NeatooJsonSerializer's global ReferenceHandler.Preserve caused ObjectWithParameterizedCtorRefMetadataNotSupported when Interface Factory methods returned records with parameterized constructors. Fix: dual JsonSerializerOptions — Neatoo types keep ReferenceHandler for $id/$ref tracking, plain records/DTOs use clean options without reference metadata. Type classification via IsNeatooType(). Breaking: non-Neatoo types no longer emit $id/$ref in JSON wire format. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ObjectWithParameterizedCtorRefMetadataNotSupportedwhen Interface Factory methods return records with parameterized constructorsJsonSerializerOptionsinNeatooJsonSerializer— Neatoo types keepReferenceHandler.Preserve, plain records/DTOs get clean options without$id/$refmetadataBreaking Change
Non-Neatoo types no longer emit
$id/$refin JSON wire format. Clients and servers must be updated together.Test plan
🤖 Generated with Claude Code