feat!: serializer responsibility redesign (v0.22.0)#45
Merged
Conversation
…ern, bump to v0.22.0 Remove ReferenceHandler from JsonSerializerOptions entirely. Converters access the resolver directly via NeatooReferenceResolver.Current (static AsyncLocal accessor) instead of options.ReferenceHandler.CreateResolver(). Delete IsNeatooType(), PlainOptions, and NeatooReferenceHandler.cs. Single JsonSerializerOptions instance, no type classification. BREAKING CHANGE: Downstream converters that access options.ReferenceHandler.CreateResolver() must migrate to NeatooReferenceResolver.Current with null check. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReferenceHandlerfromJsonSerializerOptionsentirely — reference handling is now a converter-level concern, not a serializer-level concernNeatooReferenceResolver.CurrentstaticAsyncLocalaccessor for converters to access the resolver directlyIsNeatooType(),PlainOptions, andNeatooReferenceHandler.cs— singleJsonSerializerOptions, no type classificationusing varinsideifblock caused premature disposalNeatooInterfaceJsonTypeConverter.Read()Breaking Changes
Downstream converters (including Neatoo's
NeatooBaseJsonTypeConverter) that accessoptions.ReferenceHandler.CreateResolver()must migrate toNeatooReferenceResolver.Currentwith null check. See migration guide.Test plan
🤖 Generated with Claude Code