fix: factory fetch NRE when [Fetch] returns false with [AuthorizeFactory]#47
Merged
fix: factory fetch NRE when [Fetch] returns false with [AuthorizeFactory]#47
Conversation
…ory] Generated factory Fetch methods threw NullReferenceException when the underlying [Fetch] method returned false (entity not found) and the factory had [AuthorizeFactory<T>]. The bool-false path emitted `return default!` which is null for Authorized<T>, then the public wrapper dereferenced .Result on the null reference. Fixed by emitting `new Authorized<T>()` instead of `default!` when HasAuth is true, at both the read-style and write-style local method sites. This returns a non-null wrapper with HasAccess=false and Result=null, so .Result returns null correctly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NullReferenceExceptionin generated factoryFetchmethods when[Fetch]returnsfalse(entity not found) and the factory has[AuthorizeFactory<T>]ClassFactoryRenderer.csnow emitnew Authorized<T>()instead ofdefault!on the bool-false path whenHasAuthis trueTest plan
RemoteFetch_AuthBoolFalse_ServerReturnsNull,RemoteFetch_AuthBoolFalse_ClientReturnsNull,RemoteFetch_AuthBoolTrue_ReturnsObject,RemoteFetch_RemoteAuthBoolFalse_ReturnsNull🤖 Generated with Claude Code