Conversation
|
Hi @valyntyler, thanks for the PR! Could you add a PR description explaining your feature? Please also read CONTRIBUTING.md. |
|
I'm explicitly not packaging this for NUR. I don't see how goreleaser is useful here |
|
@valyntyler to be honest I never used Nix and have no idea how packages work in that world, and I'd love if you could explain to me what your goal is. But for sure I don't like the idea of seeing a hardcoded version and SHA in the code. With your current implementation, where is the package available from? And can't one constantly release a new version to that registry instead of having to update the version manually with each version bump? |
|
You won't have to update anything manually. The version attribute is for internal use and doesn't affect the functionality of the flake. You could source it from an external file if you wanted, but for now, I've removed it. The |
|
Alright, I have multiple question then, if you don't mind
I'm asking rather than researching because you clearly know more and this would help me and other people maintain your part of the code in the future. |
Alright.
Hope this helps. P.S. |
|
The |
1: |
|
Hey, thanks allot for the long explanations, I really appreciate it even though I'm still having trouble understanding everything. I ended up asking AI to complete your answers but I think I finally got there. So you want:
Also:
I understand that but you push a PR without explanation, without following CONTRIBUTING.md and without wanting to use the tool explicitly requested for devs contributors working on this project. When I open the PR and see this, I think it's someone wanting to add a new method of installation, but then I see So correct me if I'm wrong, but from what I understand:
During my discussion with AI it also mentioned a few fixes that should be added to your commits, I'd love it if you could take a look, the full conversation is not as long as it seems. And if it is, then the last section: Bildschirmaufnahme.2026-04-01.um.00.35.05.mov |
No description provided.