Open
Conversation
Ping-Hsuan
reviewed
Feb 2, 2026
Ping-Hsuan
reviewed
Feb 2, 2026
Ping-Hsuan
reviewed
Feb 2, 2026
Collaborator
|
@nchristensen, I think setting it to 1 would be safer since I don't know how universally 0-byte memory allocation is supported (or at all). |
Collaborator
Author
|
Ah, didn't know that wasn't valid Fortran 77. I'll set it to 1 then. |
Collaborator
Author
|
@Ping-Hsuan, I think you can review the matlab files now. I've moved the old versions of some files to separate directories, that we can delete after the review is complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a MATLAB driver with a DEIM implementation as well as several supporting features:
This pull request is large, but most of it is new or moved files. There are relatively few changes to the existing files.