Skip to content

feat: vim.validate checks, annotations, code improvements#14

Closed
DrKJeff16 wants to merge 9 commits intoNeoSahadeo:mainfrom
DrKJeff16:patch/fixup
Closed

feat: vim.validate checks, annotations, code improvements#14
DrKJeff16 wants to merge 9 commits intoNeoSahadeo:mainfrom
DrKJeff16:patch/fixup

Conversation

@DrKJeff16
Copy link
Copy Markdown
Contributor

Changes

  • Added vim.validate() checks to function parameters to ensure correct data
  • Added LuaLS Annotations
  • Improved general statements
  • Autocmd callbacks grouped and exported into one
  • Exported load_cache()

Signed-off-by: Guennadi Maximov C <g.maxc.fox@protonmail.com>
Signed-off-by: Guennadi Maximov C <g.maxc.fox@protonmail.com>
Signed-off-by: Guennadi Maximov C <g.maxc.fox@protonmail.com>
@NeoSahadeo NeoSahadeo added the bug Something isn't working label Sep 14, 2025
@NeoSahadeo
Copy link
Copy Markdown
Owner

There are some issues with cache loading and there is some sort of recursive behaviour happening; switching between files (server-unload/load) which is causing memory leakage.

I will have a look an diff on Monday.

Signed-off-by: Guennadi Maximov C <g.maxc.fox@protonmail.com>
@DrKJeff16
Copy link
Copy Markdown
Contributor Author

@NeoSahadeo I just pushed a commit that removed the recursive call.

@NeoSahadeo
Copy link
Copy Markdown
Owner

NeoSahadeo commented Sep 15, 2025

The cache is no longer working (there is still some sort of recussion)

@DrKJeff16
Copy link
Copy Markdown
Contributor Author

Fan-Tastic. Lemme look into it.

@DrKJeff16
Copy link
Copy Markdown
Contributor Author

Ok, it works now (at least for me):

image

Signed-off-by: Guennadi Maximov C <g.maxc.fox@protonmail.com>
Signed-off-by: Guennadi Maximov C <g.maxc.fox@protonmail.com>
Signed-off-by: Guennadi Maximov C <g.maxc.fox@protonmail.com>
Signed-off-by: Guennadi Maximov C <g.maxc.fox@protonmail.com>
@NeoSahadeo NeoSahadeo added the invalid This doesn't seem right label Oct 2, 2025
@NeoSahadeo
Copy link
Copy Markdown
Owner

I will cherry-pick a few commits you have and push it to main.

The recursive buffer issue is fixed, but for some lsps it is erasing buffers after writing; specifically tl_ls and deno.

@NeoSahadeo NeoSahadeo closed this Oct 2, 2025
@DrKJeff16 DrKJeff16 deleted the patch/fixup branch October 2, 2025 17:45
@DrKJeff16
Copy link
Copy Markdown
Contributor Author

I will cherry-pick a few commits you have and push it to main.

The recursive buffer issue is fixed, but for some lsps it is erasing buffers after writing; specifically tl_ls and deno.

I see.

P.S. Why is it always ts_ls hahaha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working invalid This doesn't seem right

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants