Skip to content

fix: fileutils and utils improvements#19

Closed
DrKJeff16 wants to merge 6 commits intoNeoSahadeo:mainfrom
DrKJeff16:patch/fixup
Closed

fix: fileutils and utils improvements#19
DrKJeff16 wants to merge 6 commits intoNeoSahadeo:mainfrom
DrKJeff16:patch/fixup

Conversation

@DrKJeff16
Copy link
Copy Markdown
Contributor

@DrKJeff16 DrKJeff16 commented Oct 4, 2025

Changes

  • fileutils.set_file_path() always receives an argument (it's never been used optionally)
  • fileutils.save() returns a boolean instead of true|nil
  • Added a warning if fileutils.save() returns false
  • return nil --> return. The former is redundant
  • Got rid of goto continue in for loops. From experience it's problematic.
  • Simplified utils statements

@DrKJeff16 DrKJeff16 requested a review from NeoSahadeo as a code owner October 4, 2025 18:38
@DrKJeff16 DrKJeff16 changed the title chore(fileutils): set_file_path param never used optionally fix: improvements Oct 4, 2025
@DrKJeff16 DrKJeff16 changed the title fix: improvements fix: fileutils and utils improvements Oct 4, 2025
Comment thread lua/lsp-toggle/fileutils.lua Outdated
@DrKJeff16 DrKJeff16 requested a review from NeoSahadeo October 5, 2025 09:37
Signed-off-by: Guennadi Maximov C <g.maxc.fox@protonmail.com>
Signed-off-by: Guennadi Maximov C <g.maxc.fox@protonmail.com>
Signed-off-by: Guennadi Maximov C <g.maxc.fox@protonmail.com>
Signed-off-by: Guennadi Maximov C <g.maxc.fox@protonmail.com>
Signed-off-by: Guennadi Maximov C <g.maxc.fox@protonmail.com>
Signed-off-by: Guennadi Maximov C <g.maxc.fox@protonmail.com>
@DrKJeff16
Copy link
Copy Markdown
Contributor Author

DrKJeff16 commented Oct 5, 2025

@NeoSahadeo What's wrong?

@NeoSahadeo
Copy link
Copy Markdown
Owner

Merged with cherry-pick b94ed45, I needed to revert a change a4da89c; it was causing LSPs to start when the Toggle Window was opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants