Skip to content

Fix a couple of issues #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ordinalM wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix a couple of issues #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6620a5
Fix name of parameter to onConfigLoaded(); change filename for empty …
ordinalM Oct 30, 2019
51383af
remove rogue error_log()
ordinalM Oct 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions PicoZCache.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class PicoZCache extends AbstractPicoPlugin
private $cacheXHTML = false;
private $cacheFileName;

public function onConfigLoaded(array &$settings)
public function onConfigLoaded(array &$config)
{
if (isset($config['cache_dir'])) {

Expand All @@ -45,7 +45,7 @@ public function onConfigLoaded(array &$settings)
public function onRequestUrl(&$url)
{
//replace any character except numbers and digits with a '-' to form valid file names
$this->cacheFileName = $this->cacheDir . preg_replace('/[^A-Za-z0-9_\-]/', '_', $url) . '.html';
$this->cacheFileName = $this->cacheDir . (empty($url) ? 'index' : preg_replace('/[^A-Za-z0-9_\-]/', '_', $url)) . '.html';

//if a cached file exists and the cacheTime is not expired, load the file and exit
if ($this->doCache && file_exists($this->cacheFileName) && (time() - filemtime($this->cacheFileName)) < $this->cacheTime) {
Expand Down