Skip to content

MCP-Server: Support for SMB Attributes#21

Merged
jiljithcp merged 2 commits into
mainfrom
VSCP-5910
May 15, 2026
Merged

MCP-Server: Support for SMB Attributes#21
jiljithcp merged 2 commits into
mainfrom
VSCP-5910

Conversation

@jiljithcp
Copy link
Copy Markdown
Collaborator

@jiljithcp jiljithcp commented May 5, 2026

  1. Support for the following SMB attributes has been added
  • "Enable SMB Encryption"
  • "Hide SMB Share"
  • "Enable access-based enumeration (ABE)"
  1. It has now been explicitly stated that CA share is not supported for those of type Flex

  2. Also, CA share and non-browsable cannot be set together.

Testing results

  • After latest updates to PR, ...of sanity run -
    (Redacted)

  • Unified (non-Large)
    (Redacted)

  • PO
    (Redacted)

  • Unified (Large)
    (Redacted)

  • Atom (SO)
    (Redacted)

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds SMB attribute support to the volume-creation path in the Google Cloud NetApp volume tools, extending the existing create handler/schema so callers can request SMB-specific settings directly when provisioning volumes.

Changes:

  • Adds new gcnv_volume_create inputs for SMB settings and convenience SMB flags.
  • Translates and validates SMB settings in createVolumeHandler, including an early rejection for CONTINUOUSLY_AVAILABLE on FLEX pools.
  • Adds unit tests covering SMB setting mapping, invalid input handling, and FLEX CA-share restrictions.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
src/tools/volume-tools.ts Adds new SMB-related create-volume inputs and user-facing parameter descriptions.
src/tools/handlers/volume-handler.ts Builds SMB settings payloads, validates protocol compatibility, and checks FLEX restrictions before create.
src/tools/handlers/volume-handler.test.ts Adds tests for SMB flag mapping, merged settings, validation failures, and CA/FLEX behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/tools/handlers/volume-handler.ts
Comment thread src/tools/handlers/volume-handler.ts Outdated
Comment thread src/tools/handlers/volume-handler.ts Outdated
Comment thread src/tools/handlers/volume-handler.test.ts
Comment thread src/tools/handlers/volume-handler.ts
@jiljithcp jiljithcp changed the title VSCP-5910: Support for SMB Attributes MCP-Server: Support for SMB Attributes May 14, 2026
Copilot AI review requested due to automatic review settings May 14, 2026 09:59
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 12 changed files in this pull request and generated 14 comments.

Comment thread GEMINI.md Outdated
Comment thread README.md Outdated
Comment thread src/tools/handlers/storage-pool-handler.ts Outdated
Comment thread src/tools/storage-pool-tools.ts Outdated
Comment thread src/tools/storage-pool-tools.test.ts Outdated
Comment thread src/tools/handlers/storage-pool-handler.ts Outdated
Comment thread src/tools/handlers/storage-pool-handler.ts Outdated
Comment thread src/utils/netapp-client-factory.ts Outdated
Comment thread src/tools/handlers/volume-handler.ts
Comment thread src/tools/volume-tools.ts Outdated
Copilot AI review requested due to automatic review settings May 14, 2026 10:21
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 12 changed files in this pull request and generated 8 comments.

Comment thread src/tools/handlers/storage-pool-handler.ts Outdated
Comment thread src/tools/storage-pool-tools.ts Outdated
Comment thread GEMINI.md Outdated
Comment thread README.md Outdated
Comment thread src/tools/handlers/storage-pool-handler.ts Outdated
Comment thread src/utils/netapp-client-factory.ts Outdated
Comment thread src/tools/handlers/volume-handler.ts
Comment thread src/tools/storage-pool-tools.ts
Copilot AI review requested due to automatic review settings May 14, 2026 10:31
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.

Comment thread GEMINI.md Outdated
Comment thread README.md Outdated
Comment thread GEMINI.md Outdated
Comment thread README.md Outdated
Comment thread GEMINI.md Outdated
Comment thread src/tools/handlers/volume-handler.ts
Comment thread src/tools/handlers/volume-handler.ts
Copilot AI review requested due to automatic review settings May 14, 2026 11:01
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Comment thread src/tools/handlers/volume-handler.ts
Comment thread src/tools/volume-tools.ts
Comment thread src/tools/handlers/volume-handler.ts
Copilot AI review requested due to automatic review settings May 14, 2026 14:04
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Comment thread README.md Outdated
Comment thread GEMINI.md Outdated
Comment thread README.md
Comment thread GEMINI.md
Co-authored-by: Cursor <cursoragent@cursor.com>
sahoor-netapp
sahoor-netapp previously approved these changes May 15, 2026
Copilot AI review requested due to automatic review settings May 15, 2026 09:13
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Comment thread src/tools/handlers/volume-handler.ts
Comment thread src/tools/handlers/volume-handler.test.ts
Comment thread src/tools/handlers/volume-handler.test.ts
@jiljithcp jiljithcp merged commit b6404cf into main May 15, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants