Update role and user comparison logic, add tests #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
KubaZ2
commented
Jan 28, 2026
KubaZ2
commented
- Refactor Role and RestGuild comparison logic to match Discord's hierarchy rules, considering both position and ID.
- Redefine Role comparison operators (>, <, >=, <=) for correct ordering.
- Update CanManageAttribute, NormalCommands, and CustomCommandModule to use new comparison logic.
- Add RoleTest project with comprehensive MSTest unit tests for role and user comparison.
- Enable parallel test execution in test project.
- Improves correctness and test coverage for role/user hierarchy.
- Refactor Role and RestGuild comparison logic to match Discord's hierarchy rules, considering both position and ID. - Redefine Role comparison operators (>, <, >=, <=) for correct ordering. - Update CanManageAttribute, NormalCommands, and CustomCommandModule to use new comparison logic. - Add RoleTest project with comprehensive MSTest unit tests for role and user comparison. - Enable parallel test execution in test project. - Improves correctness and test coverage for role/user hierarchy.
|
The documentation preview is available at https://preview.netcord.dev/252. |
Contributor
There was a problem hiding this comment.
Pull request overview
Refines role/user hierarchy comparisons to align with Discord-style ordering (role position with ID tie-break), updates call sites to use the new comparison behavior, and adds a dedicated test project validating the new ordering semantics.
Changes:
- Redefines
Rolecomparison (CompareToand relational operators) to incorporate bothPositionandId. - Refactors
RestGuild.Compare(PartialGuildUser, PartialGuildUser)to use role comparisons and handle role-less users. - Adds a new MSTest project (
RoleTest) with unit tests for role and guild-user comparison, enabling parallel test execution.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Tests/RoleTest/RoleTest.csproj | Adds new MSTest test project referencing NetCord. |
| Tests/RoleTest/RoleComparison.cs | Unit tests validating Role comparison and operators. |
| Tests/RoleTest/GuildUserComparison.cs | Unit tests validating RestGuild.Compare user hierarchy logic. |
| Tests/RoleTest/AssemblyInfo.cs | Enables method-level parallel test execution. |
| Tests/NetCord.Test/Commands/NormalCommands.cs | Updates role sorting to rely on default role ordering. |
| Tests/NetCord.Test/Commands/Administrative/CanManageAttribute.cs | Switches manage-check logic to use guild.Compare(...). |
| NetCord/Role.cs | Implements position + ID tie-break ordering for role comparisons/operators. |
| NetCord/Rest/RestGuild.cs | Updates user comparison logic to use role ordering rules. |
| NetCord.slnx | Adds the new RoleTest project to the solution. |
| Documentation/guides/services/CustomModuleBasesAndContexts/CustomModuleBases/CustomCommandModule.cs | Updates sample role ordering to use the new default ordering. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Replaced strict 1/-1 checks with greater/less than zero in role comparison tests, making them more robust to different CompareTo implementations that may return any positive or negative value.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.