Fast rebuilds of C/C++ code when needed.#106
Merged
StephenOman merged 2 commits intoNetHack-LE:mainfrom Mar 18, 2026
Merged
Conversation
Configures `CMake` to use `ccache` for faster C/C++ compilation. Modifies `pyproject.toml` to enable `editable.rebuild` and specify `build-dir` for `scikit-build-core`, ensuring fast, incremental rebuilds when C/C++ sources or project metadata change.
StephenOman
reviewed
Mar 15, 2026
StephenOman
approved these changes
Mar 18, 2026
Collaborator
Author
|
This seems incompatible with use of Python from within the CMake build and may need rolling back. See #87 |
jbcoe
added a commit
to jbcoe/nle-nethack
that referenced
this pull request
Mar 20, 2026
This reverts commit 0b96483. Fast rebuilds with uv and scikit-build and use of Python tooling within a CMake build are incompatible. The isolated environment used for the build means that the Python executable cached in the build directory is not valid when the build directory is used for a rebuild.
StephenOman
pushed a commit
that referenced
this pull request
Mar 21, 2026
This reverts commit 0b96483. Fast rebuilds with uv and scikit-build and use of Python tooling within a CMake build are incompatible. The isolated environment used for the build means that the Python executable cached in the build directory is not valid when the build directory is used for a rebuild.
jbcoe
added a commit
to jbcoe/nle-nethack
that referenced
this pull request
Mar 21, 2026
This reverts commit 0b96483. Fast rebuilds with uv and scikit-build and use of Python tooling within a CMake build are incompatible. The isolated environment used for the build means that the Python executable cached in the build directory is not valid when the build directory is used for a rebuild.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configures
CMaketo useccachefor faster C/C++ compilation. Modifiespyproject.tomlto enableeditable.rebuildand specifybuild-dirforscikit-build-core, ensuring fast, incremental rebuilds when C/C++ sources or project metadata change.