Fixes and constrained suppression of compiler warnings#110
Open
jbcoe wants to merge 1 commit intoNetHack-LE:mainfrom
Open
Fixes and constrained suppression of compiler warnings#110jbcoe wants to merge 1 commit intoNetHack-LE:mainfrom
jbcoe wants to merge 1 commit intoNetHack-LE:mainfrom
Conversation
…x format specifier in error message
Collaborator
|
What is the purpose of limiting the noisy warning suppression to non-MVSC? |
Collaborator
Author
|
I don't think that the suppressions I have specified will work on MSVC. We could consider (or equivalent) as I think that MSVC will likely treat -Wno-deprecated-non-prototype as an unknown command-line option and trigger an error (or a warning about an invalid argument). I don't have access to MSVC to be able to check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suppress target-specific compiler warnings for non-MSVC builds
Fix format specifier in error message